Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White mid-zoom roads do not work on some backgrounds #2731

Closed
pnorman opened this issue Aug 8, 2017 · 9 comments
Closed

White mid-zoom roads do not work on some backgrounds #2731

pnorman opened this issue Aug 8, 2017 · 9 comments

Comments

@pnorman
Copy link
Collaborator

pnorman commented Aug 8, 2017

With the changes in 5fd79b7, there is a huge difference in how the roads look between different areas

image

In Surrey, the roads are readable with the residential background. In Langley, they're not, with most of them against our base colour.

@imagico
Copy link
Collaborator

imagico commented Aug 8, 2017

I noticed the same when testing the bright roads without landcover fading and found that adding a darker halo with line-comp-op: darken to the white roads helps. This will however probably look fairly heavy with the faded landcovers emphasizing roads even more and adds quite a bit of visual noise especially if the roads are not all strait like in the example you showed. I am not even sure i like it without landcover fading.

@kocio-pl
Copy link
Collaborator

I'm not sure if that's a bad thing or even regression. Midzoom changes are about intentionally hiding some details (and at this zoom level I wouldn't like them to be more visible):

Unimportant roads are now white rather than gray.

@pnorman
Copy link
Collaborator Author

pnorman commented Aug 13, 2017

I'm not sure if that's a bad thing or even regression. Midzoom changes are about intentionally hiding some details (and at this zoom level I wouldn't like them to be more visible):

If the visibility was consistent I'd see it as okay, but it's not consistent.

@matthijsmelissen
Copy link
Collaborator

For what it's worth, I agree with @pnorman that there is an issue here.

@kocio-pl
Copy link
Collaborator

What do you plan to do with it? Do you want to make any changes before v4.2.0?

@matkoniecz
Copy link
Contributor

I also agree that issue exists.

@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented Aug 22, 2017

Do you want to make any changes before v4.2.0?

I'm quite busy with other stuff at the moment, so unfortunately I won't have time to work on it the next couple of weeks. I don't think we should hold up v4.2.0 because of me. I'm fine with reverting this change to the old color, or perhaps somebody has a better solution. Rolling it out as is and improving it in 4.3.0 is also an option to me.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 22, 2017

I would probably revert this particular change as the safest choice for now. I'm pretty sure we will tune midzoom in the nearest future anyway, because it's biggest visual change from the new road system introduction 2 years ago, so there will be good opportunity to think what we could do with these roads.

@imagico
Copy link
Collaborator

imagico commented Aug 23, 2017

In case someone wants to try it - the darker halo with comp-op: darken can be found implemented in

imagico@8b82a8d

I have not tried it with the faded landcovers or in urban areas with largely unmapped landcover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants