Revert white color for unimportant roads #2769
Conversation
|
I prefer the white. |
|
We might need to re-add https://github.com/gravitystorm/openstreetmap-carto/pull/2654/files#diff-f61408bc1ffb6636dbaf2bf9e38a4177L1043 and further too. |
|
@meased I think there will be lot of discussions with other changes, so we can change this color later. @math1985 Do you mean this block only (till https://github.com/gravitystorm/openstreetmap-carto/pull/2654/files#diff-f61408bc1ffb6636dbaf2bf9e38a4177L1068) or something more? Altering road code is quite a challenge nowadays. |
|
I think so, but make sure to test it anyway. Road width might need changing too. |
kocio-pl
force-pushed
the
unimportant-roads-white
branch
from
e3a8e42 to
bafcd49
Compare
|
I'm not sure how to test it - with reverted I'm not even sure if anything more than color change was the problem to solve. |
roads.mss
Outdated
| @@ -1048,30 +1048,32 @@ tertiary is rendered from z10 and is not included in osm_planet_roads. */ | |||
| .tunnels-fill[zoom >= 10] { | |||
|
|
|||
| ::halo { | |||
| [feature = 'highway_motorway'][link != 'yes'][zoom >= 8][zoom < 12], | |||
There was a problem hiding this comment.
This block should be kept (it is the halo for low-zoom roads). So we need both blocks now.
kocio-pl
force-pushed
the
unimportant-roads-white
branch
from
bafcd49 to
edc04e9
Compare
kocio-pl
force-pushed
the
unimportant-roads-white
branch
from
edc04e9 to
6815387
Compare
|
Done and it works, anything else that should be done here? |
Resolves #2731.
Reverts unimportant roads color from white to @residential-casing color (as in v4.1.0).
Before revert:
After revert: