-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarry pattern is not periodic any more #2737
Comments
Thanks for noticing! I think we can probably safely revert this PR. Fixing problems with Mapnik rendering of SVG would be much better, of course. |
I've just found this (#937 (comment)):
This SVG is 512 px. Could it be a problem here? |
I suppose this can be easily solved by re-creating the pattern with the most recent version of jsdotpattern, that (since last sunday) also adds a dummy geometry when sanitizing, right? |
I was not aware of the change, but it works. I can merge fix, but there's still a question about all 512 px patterns. |
Anyway: As the current pattern is a regular pattern I suppose that’s not a big deal. Or course, it will round the distance to something that’s a divisor of 256, so the symbal distance might be slightly bigger or smaller, but likely < 10% difference. |
http://www.openstreetmap.org/#map=19/48.07891/7.70540
due to #2683, likely the same problem as in #2685.
The text was updated successfully, but these errors were encountered: