Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarry pattern is not periodic any more #2737

Closed
imagico opened this issue Aug 11, 2017 · 5 comments
Closed

Quarry pattern is not periodic any more #2737

imagico opened this issue Aug 11, 2017 · 5 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Aug 11, 2017

http://www.openstreetmap.org/#map=19/48.07891/7.70540

due to #2683, likely the same problem as in #2685.

@imagico imagico added the bug label Aug 11, 2017
@imagico imagico added this to the Bugs and improvements milestone Aug 11, 2017
@kocio-pl
Copy link
Collaborator

Thanks for noticing! I think we can probably safely revert this PR. Fixing problems with Mapnik rendering of SVG would be much better, of course.

@kocio-pl kocio-pl removed the bug label Aug 11, 2017
@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 11, 2017

I've just found this (#937 (comment)):

Without a fixed metatile size, this implies both pattern dimensions should be a multiple of two, and at most 256.

This SVG is 512 px. Could it be a problem here? Why 256 should be max size for patterns?

@sommerluk
Copy link
Collaborator

I suppose this can be easily solved by re-creating the pattern with the most recent version of jsdotpattern, that (since last sunday) also adds a dummy geometry when sanitizing, right?

@kocio-pl
Copy link
Collaborator

I was not aware of the change, but it works. I can merge fix, but there's still a question about all 512 px patterns.

@sommerluk
Copy link
Collaborator

Anyway: As the current pattern is a regular pattern I suppose that’s not a big deal. Or course, it will round the distance to something that’s a divisor of 256, so the symbal distance might be slightly bigger or smaller, but likely < 10% difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants