Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing quarry vector pattern #2760

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

Resolves #2737.

@sommerluk
Copy link
Collaborator

Could you make a try it with 256 px also?

@kocio-pl
Copy link
Collaborator Author

Looks good without changing generator settings:

Warsaw, z19 (click to see unscaled images):
iv6nhnxw

@kocio-pl kocio-pl requested a review from imagico August 17, 2017 20:03
Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only looking at the pattern from a technical point of view here, quarry rendering in general has so many issues now i would not really know where to start.

The suggested pattern is horizontally closed packed rather than vertically as it was before and has a larger aspect ratio mismatch - the latter however is due to an error in jsdotpattern which is now fixed and you can get a much less distorted triangle pattern with that now:

http://www.imagico.de/map/jsdotpattern.php#x,256,jdp2599;gt,45,32,32;rd,1,0,0,quarry1,1,7,6,0,jdp59560,e6e6e6,c5c3c3;

http://www.imagico.de/map/jsdotpattern.php#x,256,jdp76470;gv,45,32,32;rd,1,0,0,quarry1,1,7,6,0,jdp27974,e6e6e6,c5c3c3;

There are other options with neither the horizontal nor vertical direction accentuated but they won't work at this pattern size and density:

http://www.imagico.de/map/jsdotpattern.php#x,512,jdp69054;gt,54,32,32;tr;rd,1,0,0,quarry1,1,7,6,0,jdp25490,e6e6e6,c5c3c3;

@kocio-pl
Copy link
Collaborator Author

I personally see no problem here, but new proposition looks also good for me, so I can just use it if you want (first pattern generated and sanitized with newest jsdotpattern):

Warsaw, z19 (click to see unscaled images):
xp4efzup

@kocio-pl kocio-pl merged commit 9cdab72 into gravitystorm:master Aug 23, 2017
@kocio-pl kocio-pl deleted the quarry-svg branch August 23, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants