Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health related SVG icons #1169

Merged
merged 1 commit into from
Jan 2, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165 and focuses on health related icons.

Following symbols are affected:

amenity=hospital (slightly had to change the icon for pixel alignment) (hospital-16.svg)
hospital

amenity=pharmacy (new icon proposal) (pharmacy-16.svg)
pharmacy-16

http://www.openstreetmap.org/#map=18/46.62799/13.37186
before:
health_before

after:
health_after

@nebulon42
Copy link
Contributor Author

I noticed some oddities (more than one symbol) for hospital areas when moving from point-file to marker-file. I don't know what the reason for this might be.

@nebulon42 nebulon42 changed the title transition to SVG icons health related SVG icons Dec 20, 2014
@matkoniecz
Copy link
Contributor

@nebulon42

some oddities (more than one symbol)

Can you give examples of affected areas?

@nebulon42
Copy link
Contributor Author

Yes, sorry, I forgot. In my TileMill setup the way http://www.openstreetmap.org/way/253101687 suddenly displays the icon more than once after changing it to SVG and using marker-file.

edit: see also #1171 (comment)

@pnorman
Copy link
Collaborator

pnorman commented Dec 21, 2014

I believe you can export from inkscape rather than save and get a cleaner SVG

@nebulon42
Copy link
Contributor Author

@pnorman This is what I'm already trying to do. I'm saving as (translation of Inkscape UI might be wrong) "normal SVG" instead of "Inkscape-SVG". I think it will not get cleaner. This is not optimal, but editing files by hand is not feasible IMO.

@imagico
Copy link
Collaborator

imagico commented Dec 21, 2014

As a general remark - to properly assess the suitability of an icon you need to see it at the target scale in a typical environment. For useful feedback it would therefore be good to have sample renderings available.

Specifically here - there are various icons currently with a square or circle boundary and a symmetric symbol inside. Some of them work better with even pixel counts, some better with odd. If you want all these icons to be the same size you will have to decide on either an even or an odd number of pixels.

@nebulon42
Copy link
Contributor Author

Of course, I was already in the process of adding samples. Here they are. I think the improvement in sharpness is quite visible. Currently both crosses have the same size.

@nebulon42 nebulon42 mentioned this pull request Dec 21, 2014
9 tasks
@matkoniecz
Copy link
Contributor

Currently both crosses have the same size.

I think that in old version larger hospital icon was intentional. I also think that it was a good idea (though maybe this should be solved by showing label and icon earlier for large areas).

@nebulon42
Copy link
Contributor Author

The old version did not align to pixels and hence would cause blurriness. That's why I couldn't make it less wide. We have to deal with a lot of tradeoffs here, especially at these small sizes. If both are too similar I suggest that we should find a better/different symbol for pharmacy.

edit: maybe colouring pharmacy icon in shop colour could help making it distinctive?

@nebulon42
Copy link
Contributor Author

Sorry for changing things so often. I really like the pharmacy icon used by the Humanitarian style (CC0 from Nori icon set), it is easily recognisable and more different from hospital.

@nebulon42
Copy link
Contributor Author

The problem with markers on ways is now solved (see #1171 (comment)).

@nebulon42 nebulon42 force-pushed the svg-icons branch 2 times, most recently from ce70817 to c0d4233 Compare December 22, 2014 21:58
@matthijsmelissen
Copy link
Collaborator

Looks nice. I'd propose to merge the new icons not in the version which is about to be released, but in the one after that.

@pnorman
Copy link
Collaborator

pnorman commented Dec 30, 2014

I'm really going to have to get used to the sharper look.

gravitystorm added a commit that referenced this pull request Jan 2, 2015
@gravitystorm gravitystorm merged commit 61990a5 into gravitystorm:master Jan 2, 2015
@nebulon42 nebulon42 deleted the svg-icons branch January 2, 2015 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants