-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding amenity=clinic icon #1565
Conversation
sounds like a tagging problem, if it's big I'd rather use the hospital tag even if it's called "clinic" in your language, for reference see here and here(eg): |
The name is not important, the tagging is, and this example shows this (I also know some fast foods with "restaurant" in the name). |
I'm not sure if clinic should get its own icon. Maybe either hospital or doctors icon? This one is a bit too close to hospital. I have no different proposal for another icon though. For me the concept of clinic is not yet clear, maybe because we don't have them here. |
See the discussion in #763 - I already asked about how should it look like and ended up with it (cross alone was the first idea, however I was not really satisfied with it). I would like more people replying, but the response was too weak to really know, so I decided it would be good to be like this. |
Yes please. The concept fits for different aggregations of doctors in different cultures, or a rural facility that is visited by a doctor regularly. In eastern Europe you have Polyclinics, in Germany you have the Ärztehaus, an aggregation of legally independent (self-employed) doctors in one building. From the mapping perspective, that is easier to tag in the first step than researching a dozen surgeries within. The lighter cross in the circle works well in proximity to a hospital, but is harder to recognise when on its own. Maybe the doctor's bag with a circle, or a roof? |
I will try with the circle, but what's the metaphor/rationale behind adding roof to the doctor's bag? |
doctor's bag currently used for amenity=doctors, and clinic would be "a house of doctors", roughly translating the German "Ärztehaus". A plurality of doctors in the icon would be even better, but I have no idea how to symbolise that in a small icon. |
clinic is a bad tag because it is ambiguous (several meanings), so it remains unclear what kind of object it is |
Doctor's bag would be fine for me, but let's wait for other opinions. |
Sure - the more opinions, the more probability of doing something in a proper way. |
After reading the wiki pages (also on doctors and health care proposals) I'm inclied to say that the doctor's bag alone is enough for "clinic". It's kind of the lowest common denominator: there will be medical help at the location, but it can be much less than a full hospital, so we should not have an icon that might be mistaken for a hospital. |
+1 for doctor's bag. |
df840b9
to
e826e23
Compare
General question: when should I merge new master changes? I've been fixing merge conflicts few times already with my PRs and it was good as a learning experience, but it's tedious and error prone (very long YAML lines...), so I'd rather do it only when I know someone wants to merge given PR. |
If it's simple changes I guess we can resolve the conflicts when we do the merging. |
@@ -143,7 +143,7 @@ Layer: | |||
FROM (SELECT | |||
way, COALESCE(name, '') AS name, | |||
('aeroway_' || (CASE WHEN aeroway IN ('apron', 'aerodrome') THEN aeroway ELSE NULL END)) AS aeroway, | |||
('amenity_' || (CASE WHEN amenity IN ('parking', 'bicycle_parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard', 'prison', 'place_of_worship') THEN amenity ELSE NULL END)) AS amenity, | |||
('amenity_' || (CASE WHEN amenity IN ('parking', 'bicycle_parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard', 'prison', 'place_of_worship', 'clinic') THEN amenity ELSE NULL END)) AS amenity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change the landcover layer?
I treat the clinic as a hospital, so if it's big enough, we should indicate it IMO (still it's less important, so icon is rendered bit later). I would also do it for doctor's office, because I know some of them that occupy the whole building and the area around it. |
Here is an example of doctor's office which is big, and here we have a hospital that probably does not occupy even one full building (I know both, so it's not a mistake). The differences between doctor's office, clinic and the hospital are rather blurry then, because one may think it's the size which helps recognize them, but it's not, and the name can be also misleading. That's why I support rendering areas for all such amenities as we do with hospital currently. I think different icons and zoom levels are good hints how important health facility may it be, but the area rendering should depend only on the size. |
At least in Canada, clinics are much more similar to a doctor's office than a hospital. A doctor's office and a clinic will tend to have similar levels of care and equipment and are outpatient facilities, while a hospital will tend to be much more advanced and include things like emergency care, inpatient beds, dedicated specialty departments (e.g. renal, oncology, ICU, maternity), etc. My opinion is that the doctor's bag would be the best choice, or possibly another different icon if someone can think of one. For me, anything similar to the hospital icon is a no-go, since they're very different facilities. |
I see the doctors bag is on the map now for clinic, a choice I find to be odd since many clinics, particularly in rural 3rd world, don't have doctors but nurses - with occasional visits by doctors. I would have liked to see the thinner cross proposed at the top here instead, particularly useful also when marking wards/clinics in larger hospitals. Knowing which hospital you are going to isn't enough when it is spread around, for example Landspítalinn in Iceland is in 3 different locations spread around Reykjavík and 2 of those locations are very big with many buildings and many different entrances for different clinics. Bring back the circle! |
Resolves #763.
You can compare it with the hospital icon. As clinic may be similar, a part of the hospital (as here) or just something like doctors, it's similar to hospital, but rendered later and with less prominent name.
z16
![clinic-after-z16](https://cloud.githubusercontent.com/assets/5439713/7737922/7cb7c3d2-ff4f-11e4-93be-1b6b6484c122.png)
z17
![clinic-after-z17](https://cloud.githubusercontent.com/assets/5439713/7737928/874922e6-ff4f-11e4-830c-2513fd4e21f6.png)
z18
![clinic-after-z18](https://cloud.githubusercontent.com/assets/5439713/7737932/8e874600-ff4f-11e4-93d1-eee9f0cef706.png)
z19
![clinic-after-z19](https://cloud.githubusercontent.com/assets/5439713/7737935/96dc7f8c-ff4f-11e4-880c-d6efd9223bbe.png)