Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move telephone icon to SVG #1607

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.

before
phone_before

after
phone_after

@nebulon42 nebulon42 mentioned this pull request Jun 9, 2015
66 tasks
@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 9, 2015

I guess the arch should be more visible to make the shape easier to recognize, but overall impression is good.

@mboeringa
Copy link

What if you drop the small gap between handle and speaker/microphone, have you tried that? I don't think it is actually necessary, and makes it slightly less recognizable (also in the "emergency" variant).

I know the gap is there in the original one, but it is so small, so as to be virtually invisible on coarse low dpi screens...

@daganzdaanda
Copy link

Agree about the gap not being necessary. Otherwise, good icon.

@matthijsmelissen
Copy link
Collaborator

@nebulon42 Have you looked into dropping the gap?

@nebulon42
Copy link
Contributor Author

I like the gap better. I have also to make sure that my icons still look good at bigger sizes, even if that is not a concern for this style. It's a concern that I have to have.

Without gap: telephone-141 telephone-142

I can offer a less wide gap though and have updated the branch:
telephone

@daganzdaanda
Copy link

I'm fine with the smaller gap, actually it's better than the full version.

@kocio-pl
Copy link
Collaborator

+1

@matkoniecz
Copy link
Contributor

Yes, smaller gap works really well.

@mboeringa
Copy link

Looks acceptable now.

@nebulon42
Copy link
Contributor Author

Rebased. Since the smaller gap is accepted this should be ready for review/merge now.

@matkoniecz
Copy link
Contributor

Thanks for the new icon!

matkoniecz added a commit that referenced this pull request Jul 6, 2015
@matkoniecz matkoniecz merged commit 510b7b8 into gravitystorm:master Jul 6, 2015
@nebulon42 nebulon42 deleted the svg-phone branch July 7, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants