Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop incorrect text class from text-line #1944

Merged
merged 2 commits into from
Nov 15, 2015

Conversation

matthijsmelissen
Copy link
Collaborator

This saves 4 out 20 seconds on ever Carto-run on my system, and was a bug
anyway.

See also #1941.

This saves 4 out 20 seconds on ever Carto-run on my system, and was a bug
anyway.
@rrzefox
Copy link

rrzefox commented Nov 1, 2015

It also decreases the size of the resulting .xml by more than 150 kB for me, which is impressive.

@pnorman
Copy link
Collaborator

pnorman commented Nov 1, 2015

Isn't this used in water-features.mss?

.text {
  [feature = 'waterway_dam'],
  [feature = 'waterway_weir'] {
    #text-poly[zoom >= 15],
    #text-line[zoom >= 15],
    #text-point[zoom >= 17] {
      ...
      #text-poly {
        ...
      }
      #text-line {
        ...
      }
      #text-point {
        ...
      }
    }
  }

  [feature = 'man_made_breakwater'][zoom >= 15],
  [feature = 'man_made_groyne'][zoom >= 15],
  [feature = 'man_made_pier'][zoom >= 15] {
    #text-poly,
    #text-line {
      ...
      #text-poly {
        ...
      }
      #text-line {
        ...
      }
    }
  }
}

@matthijsmelissen
Copy link
Collaborator Author

Yes, thanks for catching.

@matthijsmelissen
Copy link
Collaborator Author

Fixed, performance speed-up is still the same.

@matthijsmelissen
Copy link
Collaborator Author

@pnorman Could you review this and #1947 by any chance?

@pnorman pnorman merged commit eff987c into gravitystorm:master Nov 15, 2015
@matthijsmelissen matthijsmelissen deleted the text-line-class branch February 9, 2016 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants