Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git workflow guidelines to contribute on this repo #2334

Closed
wants to merge 1 commit into from

Conversation

Ircama
Copy link
Contributor

@Ircama Ircama commented Sep 8, 2016

Add git workflow guidelines to contribute on this repo

With this PR I would like to submit the first version of a new document for revision.
It provides step-by-step instructions for using git with OpenStreetMap Carto and suggests guidelines on how contributors should operate when collaborating through pull requests (PRs) via Git and GitHub.

This document suggests guidelines on how contributors should operate when collaborating to OpenStreetMap Carto through pull requests (PRs) via Git and GitHub.
@pnorman
Copy link
Collaborator

pnorman commented Sep 8, 2016

I would much rather point at external documentation. We are currently doing that in workflow with a link to github's pull request guidance.

When we added the link it contained text about the fork & pull model but it's not there anymore. We could link to https://help.github.com/categories/collaborating-on-projects-using-issues-and-pull-requests/. The fork and pull model is defined in https://help.github.com/articles/about-collaborative-development-models/

The two relevant parts of that category seem to be https://help.github.com/articles/working-with-forks/ and https://help.github.com/articles/proposing-changes-to-a-project-with-pull-requests/. Would linking to those two work?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 8, 2016

Related to #2291.

@matthijsmelissen
Copy link
Collaborator

I agree nearly everything described in this pull request is the standard Github workflow, so I don't think this repository is the best place to describe this. It would indeed be great if we can link to some external places where contributors can find more information.

@Ircama
Copy link
Contributor Author

Ircama commented Sep 9, 2016

I agree nearly everything described in this pull request is the standard Github workflow

OK to move this document in some other place. Which are the most mismatching aspects in order to improve it?

@pnorman
Copy link
Collaborator

pnorman commented Sep 13, 2016

Closing and opening an issue for the stale link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants