Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fix for uniform layers code #2506

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

kocio-pl
Copy link
Collaborator

Small fix to make layers code more uniform, as discussed in #2429.

@pnorman pnorman merged commit 5a84e77 into gravitystorm:master Dec 12, 2016
@kocio-pl kocio-pl deleted the layer-uniform-fix branch December 12, 2016 03:28
@nebulon42
Copy link
Contributor

Related here: carto 0.17 will mark name as deprecated and it will be removed in carto 1.0.

@kocio-pl
Copy link
Collaborator Author

Do we need names? If not, we could remove names right now and stay with just ids.

@nebulon42
Copy link
Contributor

nebulon42 commented Dec 13, 2016

If we use any selectors of the form #layername then all versions of carto up to now need names. This needs a longer transition period.

See also mapbox/carto#165 (comment) for details of the change.

@Ircama
Copy link
Contributor

Ircama commented Dec 13, 2016

Is the id or the name tag which references an identifier of the form #layername?

@pnorman
Copy link
Collaborator

pnorman commented Dec 13, 2016

I think only name is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants