-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shop=tyres rendering #2662
Conversation
Any comments/reviews about it? |
I cleaned the icon a bit and made it 12px tall to leave 1 px margin in a 14 px icon. Was that the way the other icons were sized?? It seems very tiny... https://gist.github.com/daganzdaanda/d0e644e0fa1844597f800d0aedddc372 |
It kind of looks like there's a perspective to the icon, although that could also be a tyre on the left and a rim on the right. |
@daganzdaanda No, most of the icons are using 14px matrix, so you don't have to resize it. |
I have trouble deciding about merging this code. "A pull request should have at least one review before it is merged" (#2436 (comment)) - but do we need formal review (like this one) or any comment indicating that other developer have seen it (like this)? The problem is lack of review or reaction is common situation with our PRs, so decision making process is still not quite effective. |
For me this means a formal review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the second icon shown, as I find it just as clear, and fits with our style guidelines.
Related to #2619
shop=tyres is the last of very popular shop types - above 10k uses - which have no special icon (the other one is shop=boutique, but it was rejected 2 years ago). This icon was designed by @MaestroGlanz and I find it good enough for this style: