-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing borders color to gray [WIP] #2695
Conversation
Crowded city centers would be interesting |
It looks very good on low- and mid-zooms, but I'd like to see some high-zoom examples, especially places where borders crosses or goes along other elements of map |
Could you give some examples to test? |
A few places found fast, if you need, I can give more of it later |
The most convenient would be something included in Metro extracts. |
The most serious problem at the low/mid zooms with grayish borders is interference with railways at z7 and above. The German style using a somewhat greenish tone (much less green though than the old German style) is doing a bit better here but not really great: https://mc.bbbike.org/mc/?lon=9.948721&lat=51.108173&zoom=7&num=2&mt0=mapnik-german&mt1=mapnik At the high zooms you are also going to have interference with cliff: https://mc.bbbike.org/mc/?lon=6.745563&lat=46.339865&zoom=13&num=2&mt0=mapnik-german&mt1=mapnik cc @giggls. |
Thanks for raising these issues. Borders rework may include different pattern and changing levels like it's discussed in #622. I'd like to start with extending new midzoom landuse colors for low zoom to see how they will interact with borders. Green is unlikely (there will be more trees), but maybe gray+violet tint could work? @nebulon42 wants to publish lowzoom tool which will save z8 landuses, so testing can take only reasonable time. |
There are many other changes related to midzoom going right now, so I close this PR. Borders needs probably more in-depth discussion anyway than this trivial color change. |
Related to #622.
Related to #3526.
Simple color change for the borders from violet to gray. Examples:
Warsaw, z12
Before
After
Europe, z4 (see more examples here)
Before
After (borders)
After (borders+water)