Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering natural=sand earlier on midzoom #2738

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Aug 12, 2017

Related to #2654, follow up to #2722.

Another landuse type that can be rendered on midzoom on z8+ (instead of z9+), just like the forest and farmland, because there are already places where it can be quite big (=visible even on the low zoom scale) and it helps diversity.

@rrzefox: Could you add this patch too and check the performance implications?

Examples (click to see unscaled images):

Egypt, z8
wvvtbkza

Africa, z8 (converted to JPG to fit in GitHub filesize limit)
-> link to big image

@sommerluk
Copy link
Collaborator

Could you remove the Africa image itself from this PR description and leave only the download link to https://user-images.githubusercontent.com/5439713/29237544-a19b77fe-7f20-11e7-956c-9b9129ee4e42.jpg

It’s so big, it crash’s my browser(s) and even my image preview… 😉

Anyway an intresing image. So not much of the Sahara sand is currently mapped in OSM…

@kocio-pl
Copy link
Collaborator Author

Update - names should also render earlier, especially since these tend to be named, big areas:

Egypt, z8 (click to see unscaled images):
bqwlj6xx

@rrzefox
Copy link

rrzefox commented Aug 14, 2017

@rrzefox: Could you add this patch too and check the performance implications?

added and rererendered Z 8 and 9; Your example area would be roundabout here: https://osm.rrze.fau.de/map-ll-osm?zoom=8&lat=28.919&lon=27.745&layer=RRZE%20tileserver%20osm.org%20style%20tiles
Looking at rendering times of randomly selected metatiles I see no mayor performance impact (but take this with a grain of salt: This is a server rendering usually multiple tiles in parallel, sometimes live, so the fluctuation from that will be so big that a performance impact of a few percent simply isn't measurable).

@kocio-pl kocio-pl merged commit 04ddedb into gravitystorm:master Aug 15, 2017
@kocio-pl kocio-pl deleted the sand branch August 15, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants