Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for amenity=casino #3285

Merged
merged 6 commits into from
Jul 11, 2018
Merged

Add rendering for amenity=casino #3285

merged 6 commits into from
Jul 11, 2018

Conversation

meased
Copy link
Contributor

@meased meased commented Jul 3, 2018

Fixes #3210

Adds rendering for amenity=casino

This marked as WIP as I think there are a couple of decisions to make:

  1. amenity=casino + tourism=hotel are likely to occur on the same building (I think), which should have higher priority?
  2. What zoom level to start on? 16 "feels" the best on the test areas, but hotels start at 17.

Test areas (you would think Las Vegas would be a good test area, but there is surprisingly bad tagging there):

https://www.openstreetmap.org/#map=16/48.0883/-122.1897
Before
tulalip_before_16
tulalip_before_17

After
tulalip_16
tulalip_17

https://www.openstreetmap.org/#map=17/44.99815/-124.00950
Before
chinook_before_16
chinook_before_17
After
chinook_16
chinook_17

https://www.openstreetmap.org/#map=16/45.8534/-122.7062

Before
ilani_before_16
ilani_before_17
ilani_before_18

After
ilani_16
ilani_17
ilani_18

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

I like how the icon looks - it's clear for me.

@meased meased changed the title WIP: Add rendering for amenity=casino Add rendering for amenity=casino Jul 8, 2018
@meased
Copy link
Contributor Author

meased commented Jul 8, 2018

I have removed the WIP status of this PR. The issue I had was that when zooming in to an object tagged with both casino and hotel, the rendering would switch from casino to hotel, which I found jarring. I have fixed this by preferring the casino rendering. (Though I had a hard time finding examples of areas tagged like this so maybe it's not so common after all.)

I am open to other solutions/suggestions.

@lakedistrictOSM
Copy link

I'd probably go for z17 over z16 - z16 seems too early, especially in places like the UK where casinos are much smaller than those in the USA.

@lakedistrictOSM
Copy link

(Though I had a hard time finding examples of areas tagged like this so maybe it's not so common after all.)

Stick amenity=casino and tourism=hotel global into the wizard on overpass turbo

@Tomasz-W
Copy link

Tomasz-W commented Jul 9, 2018

As more often casino is a part of hotel, not the opposite, I think tourism=hotel should have the priority.

@meased
Copy link
Contributor Author

meased commented Jul 9, 2018

I'd probably go for z17 over z16

This is probably the best solution. Hotels render at 17 so the issue resolves itself.

@meased
Copy link
Contributor Author

meased commented Jul 10, 2018

Rendering now starts at z17, the same as hotel. No rendering change for places tagged with hotel and casino. Other rendering are the same as the above samples (just disregard the z16 images).

@kocio-pl kocio-pl merged commit ace1270 into gravitystorm:master Jul 11, 2018
@kocio-pl
Copy link
Collaborator

Thanks, it looks sane and works with both nodes and ways.

@imagico
Copy link
Collaborator

imagico commented Jul 11, 2018

Seems i am somewhat late in commenting here - i hadn't noticed the 'WIP' note had been removed and given the controversial nature of the subject i had expected a broader discussion before such a change would be merged.

amenity=casino is the tag for a gambling establishment, i.e. a place where money is bet on the outcome of certain games. This is something fundamentally different from the main purpose games have in most societies in general, namely amusement and social interaction. This means the symbol chosen here is likely misleading for a significant fraction of potential map users by implying games but not in any way indicating the gambling aspect. This alone would IMO make the symbol unsuitable for this kind of feature (misleading to the map user and wrong incentive to the mapper to tag anything came related as amenity=casino). And given the addictive potential of gambling you could in this case consider the choice of symbol as trivializing addiction risks. Showing casinos on the map is one thing, showing them in a way that is likely to indicate to the unsuspecting user this could be a place to play games for recreation and social interaction is something very different.

@kocio-pl
Copy link
Collaborator

Dices are traditionally related to gambling, so I see nothing wrong with using them as a symbol of casino. For shop=games (which has still low usage) I would rather use chess figure for example.

@matthijsmelissen
Copy link
Collaborator

Agree with @kocio-pl.

@imagico
Copy link
Collaborator

imagico commented Jul 11, 2018

When viewed globally dice are certainly far more used as a device for amusement and social interaction games than for gambling. So i stand by my comment. A huge fraction of the potential map users observe recreational dice games in public on a daily basis but have not seen a casino up close in their whole life. In Europe today recreational games played in public play a very small role compared to other parts of the world. This combined with the strong presence of casino games in contemporary movies and television might give you a selective impression of the subject.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 11, 2018

Recreational dice games in public are not too popular. I'm not even sure if we have tagging for this - probably it's just what can happen in some games shops.

I also think that showing risk-related places (like military area, alcohol shop or casino) might as well make people avoid such areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon for amenity=casino
7 participants