-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for amenity=casino #3285
Conversation
I like how the icon looks - it's clear for me. |
I have removed the WIP status of this PR. The issue I had was that when zooming in to an object tagged with both casino and hotel, the rendering would switch from casino to hotel, which I found jarring. I have fixed this by preferring the casino rendering. (Though I had a hard time finding examples of areas tagged like this so maybe it's not so common after all.) I am open to other solutions/suggestions. |
I'd probably go for z17 over z16 - z16 seems too early, especially in places like the UK where casinos are much smaller than those in the USA. |
Stick |
As more often casino is a part of hotel, not the opposite, I think |
This is probably the best solution. Hotels render at 17 so the issue resolves itself. |
Rendering now starts at z17, the same as hotel. No rendering change for places tagged with hotel and casino. Other rendering are the same as the above samples (just disregard the z16 images). |
Thanks, it looks sane and works with both nodes and ways. |
Seems i am somewhat late in commenting here - i hadn't noticed the 'WIP' note had been removed and given the controversial nature of the subject i had expected a broader discussion before such a change would be merged.
|
Dices are traditionally related to gambling, so I see nothing wrong with using them as a symbol of casino. For |
Agree with @kocio-pl. |
When viewed globally dice are certainly far more used as a device for amusement and social interaction games than for gambling. So i stand by my comment. A huge fraction of the potential map users observe recreational dice games in public on a daily basis but have not seen a casino up close in their whole life. In Europe today recreational games played in public play a very small role compared to other parts of the world. This combined with the strong presence of casino games in contemporary movies and television might give you a selective impression of the subject. |
Recreational dice games in public are not too popular. I'm not even sure if we have tagging for this - probably it's just what can happen in some games shops. I also think that showing risk-related places (like military area, alcohol shop or casino) might as well make people avoid such areas. |
Fixes #3210
Adds rendering for amenity=casino
This marked as WIP as I think there are a couple of decisions to make:
Test areas (you would think Las Vegas would be a good test area, but there is surprisingly bad tagging there):
https://www.openstreetmap.org/#map=16/48.0883/-122.1897
Before
After
https://www.openstreetmap.org/#map=17/44.99815/-124.00950
Before
After
https://www.openstreetmap.org/#map=16/45.8534/-122.7062
Before
After