Added text-repeat-distance for railways (part of #3295) #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tomasz-W: done; thanks for noticing. |
|
I guess 200 is enough and could work better than 600: Before 200 600 |
|
@kocio-pl: agreed, 200 seems enough. I found some corner cases, but they may be explainable by differences in labels, as even a 600 value doesn't remove the duplicated labels just 50px apart. |
|
Great, could you make new batch of test rendering of the same places as before? I will check it on some others. |
|
Looks OK for me - Tokyo example: Before After |
|
Thanks for this part! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
text-repeat-distanceon railways texts, to avoid uselessly cluttering the map by repeating the labels to close of one another; this partly supersedes #3295 which was to be split in several PRs. This includes the removing of the conflicting, deprecatedtext-min-distance.Test renderings, before/after:
https://www.openstreetmap.org/#map=15/49.0035/5.9582
https://www.openstreetmap.org/#map=15/49.0075/6.0320
https://www.openstreetmap.org/#map=16/49.0971/6.1663
Edit: fixes #2783; added links to test locations.