Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intermittent waterbody rendering of basins #3502

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Improve intermittent waterbody rendering of basins #3502

merged 1 commit into from
Nov 11, 2018

Conversation

jragusa
Copy link
Contributor

@jragusa jragusa commented Nov 8, 2018

Fixes #709

Changes proposed in this pull request:
Add support of basin=detention and basin=infiltration in int_intermittent variable

Test rendering with links to the example places:

basin=detention https://www.openstreetmap.org/way/220462429
Before
basin_detention_before
After
basin_detention

basin=infiltration https://www.openstreetmap.org/way/234418071
Before
basin_infiltration_before
After
basin_infiltration_after

basin=infiltration https://www.openstreetmap.org/way/532562272 (no modification)
basin_retention_after

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 8, 2018

Just to make it clear: retention basins rendering is not changed, because basin=retention by definition does not loose water, while basin=detention and basin=infiltration do:

https://wiki.openstreetmap.org/wiki/Tag:landuse%3Dbasin#Tags_used_in_combination

@jragusa
Copy link
Contributor Author

jragusa commented Nov 8, 2018

Exactly, basin=retention is not included following your comment. Only basin=detention and basin=infiltration are considered

@jragusa
Copy link
Contributor Author

jragusa commented Nov 10, 2018

@kocio-pl I have updated the description with additional examples

@kocio-pl kocio-pl merged commit 5718e44 into gravitystorm:master Nov 11, 2018
@kocio-pl
Copy link
Collaborator

Thanks! This is a simple, but useful change to make people aware of the difference between tagging retention and detention basins.

@jragusa jragusa deleted the basin branch November 25, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants