Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify low-zoom landcover rendering to 4 main colors (requires 3 water colors) #3670

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Simplify low-zoom landcover rendering to 4 main colors (requires 3 water colors) #3670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7346ad
Simplify low-zoom landcover rendering to 4 main colors
jeisenbe Jan 23, 2019
c3af0f6
Change river-color to #8fcadd, water-color to #a2d1e0
jeisenbe Feb 5, 2019
7085957
Change to ocean polygons, move ocean and water above water-lines
jeisenbe Feb 5, 2019
ab38107
Change ocean-color to #b5d7e3 Lch(84,13,227)
jeisenbe Oct 7, 2019
ec2f0a2
Fix intermittent river pattern
jeisenbe Mar 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions project.mml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ Layer:
way,
"natural",
waterway,
water,
Copy link
Collaborator

@kocio-pl kocio-pl Nov 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Since GitHub lacks general comments for reviews, I attach it to the first change, to make clear what problems need to be fixed - sorry)

There are two problems I see here:

  • dark wood spots (this is exactly the same problem as it was when testing color fading changes) - a blocker for me
  • I have a big question about what problem exactly resolves reducing colors at low zoom? The whole rationale is about fixing problems which will be probably fixed by Reduce landcover fading at mid-low zoom levels #3952, it's not clear what this particular solution would change in comparison

landuse,
way_area/NULLIF(POW(!scale_denominator!*0.001*0.28,2),0) AS way_pixels,
CASE WHEN tags->'intermittent' IN ('yes')
Expand Down
Loading