-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borders rework #3716
Borders rework #3716
Conversation
Change country and state placenames text color to match new borders color
Thanks, I will try to review it soon. |
Most of the comments i made on #3666 apply here too. This change has the advantage of a consistent rendering of boundaries at each individual zoom level but the color relationships would be different for every zoom level which would significantly complicate color design in the future - you could no more design other colors to work harmonically together with the boundary color, you would need to design them to work together with each of the different boundary colors for every zoom level. |
you could no more design other colors to work harmonically together with the boundary color, you would need to design them to work together with each of the different boundary colors for every zoom level.
That’s why I limited the change to < z8, because primary roads and railways begin to be shown at z8, as well as protected area borders and large landcover area labels.
At z6 and z7 there are few linear features shown (motorways, trunk roads, country and state borders, some rivers), no icons except cities, the only text labels should be countries, cities, provinces/states (and perhaps seas/oceans) and hopefully only 4 colors of landcover will be shown in the future.
I could also reduce the transition to only one intermediate color, if 4 different border colors is considered excessive; then the transition could be at z5 to z7 or even z4 to z6, where it is unlikely that we will use more than a handful of colors (motorways and trunk roads start at z6). Would this be worthwhile?
|
Could you explain what problems exactly this change is supposed to fix specifically by changing the boundary color at z1-z7? If the purple color is considered disadvantageous the logical step would IMO be to change it universally. If that is considered non-feasible because of other constraints that only exist at the higher zoom levels i don't think selectively re-designing the low zoom levels is the way to go. It would swap one problem (finding a boundary design that works on all zoom levels) with a different one (making any styling decisions in the future that affect both low and high zoom levels) which is more severe than the first. I would rather look into solving the high zoom level constraints in question instead. My main problems with the purple boundary color are that
Neither of these issues would be fixed by your change. |
It's just a design improvement. The current color palette at high zoom levels (z1 to z4) is the blue water color, black labels, off-white / light gray land color, and the purple border color (in two versions, mixed with water and mixed with land). The blue and purple alone are a strange combination, at least in Western culture* At z5 to z7 there are also some very faint shades of green in areas of landcover, red motorways and red-orange trunk roads. The purple still looks out of place compared to the red / green / blue primary colors of the other features, at these zoom levels. At high zoom levels (>14), the addition of darker landcover colors, and more colors of roads, railways etc. makes the purple a reasonable choice, although it is a quite strong color
That's true, and you are correct that this PR would not fix that problem. Overall, I agree that trying a shade of green/gray similar to the Germany or French stylesheet would be superior at mid and high zoom levels, but I thought this idea had been rejected previously. *[My favorite Papuan shirt has a bright to mid-blue batik background with purple drums and spears, outlined in black and metallic gold]. |
So you say at low zoom the purple boundaries look strange/out of place but at high zooms less so because there are more other colors anyway. I see several problems with that:
One question i would like to ask is: Under the assumption that you want a consistent boundary design across all zoom levels what would be the best choice for this - including options that use a different approach than the current plain semitranparent line and including options that might require other design changes to work. IMO only if you come to the conclusion that the answer to that question is still a bad choice specifically at some zoom levels but not at others you should consider differentiating design between zoom levels. But i would like to hear other opinions on this matter. My assumption has always been that we aim for design continuity across all zoom levels - both for map the map user and for developers for less complications in design - but there are quite a few map styles out there (one of the most obvious being OpenTopoMap) which make a deliberate choice for a low/high zoom discontinuity. |
Closing, it will be easier to continue work on a different PR and separate out the changes. |
This supersedes two earlier PRs: #3553 and #3666
Fixes #3489
Closes #3526
Related to #621, #3102, and #3563
Changes proposed in this pull request:
Explanation:
Some map users and style maintainers have complained that the current border color is too prominent, especially at low zoom levels.
Several years ago, the z1 to z3 borders were shown in gray, while all other zoom levels were in #ac46ac - this was changed in a PR which I cannot find at this time.
This PR changes the low-zoom borders to use color palette that is much less saturated for z5 and below (#ac46ac +75% of grey = #6b516b), transitioning at z6 to z8 to the current color
#ac46ac
.The line thickness is adjusted so that there is a more gradual transition, and the dashes are continued to low zoom levels for admin_level=4 to be consistent.
The labels for admin_level=2 and 4 areas (countries and provinces) are changed to a less saturated color, so country labels font is changed to bold to be more distinctive. The half-character spacing is removed for better rendering with non-Latin scripts.
[The author of this PR would also be happy with gray-green borders as in the German style, but this PR is offered in hopes of achieving consensus.]
Test renderings:
Libya - Before
Libya z5
Libya z6
Libya z7
Libya z8
Libya z9
Libya - After
z5 Libya - after
z6 Libya - after
z7 Libya - after
z8 Libya - after
z9 Libya - after
Shikoku, Japan - Before
z5 Shikoku before
z6 Shikoku before
z7 Shikoku before
z8 Shikoku before
Shikoku - After
z5 Shikoku grayish borders
#6b516b
z6 Shikoku grayish
#814d81
z7 Shikoku grayish
#964a96
z8 Shikoku Same as current
#ac46ac
Latvia - before
z5 Latvia before
z6 Lativa before
z7 Lativa before
z8 Lativa before
Latvia - after
z5 Latvia after
z6 Latvia after
z7 Latvia after
z8 Latvia after
Venezuela - Before
z5 Venezuela before
z6 Venezuela before
z7 Venezuela before
z8 Venezuela before
Venezuela After
z5 Venezuela after
z6 Venezuela after
z7 Venezuela after
z8 Venezuela after
Border text labels
z11 Latvia before
z11 Latvia after
z12 Caracas, Venezulea before
z12 Caracas after
z11 Libya before
z11 Libya - after