-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render vaccination_centres. #4300
Conversation
The icon is a 10px hospital one, as I couldn't find any that looked like a syringe :) |
We cannot re-use the hospital icon while telling mappers not to tag the vacc-centres as hospital. |
Thanks for the submission - code looks fine, although i have not tested it. Right now i see the following problems with this:
|
This tag has been approved recently: https://wiki.openstreetmap.org/wiki/Proposed_features/Tag:healthcare%3Dvaccination_centre
Let's use that one too, then.
Let's narrow down the filters then. Any suggestions?
Yeah, I put the hospital icon just to prove the SQL query works. Does anyone know a syringe icon somewhere? I will try to find one myself, but my time is quite limited. |
It's unlikely to find an icon matching the requirements here, which is a 14px-optimised monochrome svg. |
While I was personally involved in creating this tag, I don’t think it is well established enough to render right now, considering that we don’t render more common tags like healthcare=laboratory. However, it would be worth considering adding rendering along with a few of the most common healthcare=* tags once it is more common - see https://wiki.openstreetmap.org/wiki/Template:Map_Features:healthcare Perhaps we could use a generic, abstract icon such as a filled circle, rather than creating new icons for each feature? See also #3635 for discussion about the abundance of icons in this style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR currently would not render the names of healthcare=vaccination_centre features. That would require adding this to line 2552:
openstreetmap-carto/style/amenity-points.mss
Line 2552 in d13ed55
[feature = 'healthcare_yes'] { |
@@ -593,6 +593,13 @@ | |||
marker-clip: false; | |||
} | |||
|
|||
[feature = 'healthcare_vaccination_centre'][zoom >= 15] { | |||
marker-file: url('symbols/amenity/hospital.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symbol needs to be changed, as discussed, either to a generic icon which can be used for a number of healthcare features which are currently not yet rendered (e.g. laboratories, test centres, birth centres, midwives, nurses, chiropractors, acupuncture, etc) or a unique symbol needs to be created which is recognizable, e.g. a syringe.
Those look very good. The other issues mentioned in #4300 (comment) still apply of course. Considering as mentioned vaccination opportunities are often tagged with addon tags (healthcare:speciality=vaccination, vaccination=*) to various medical facilities it could be worth trying to indicate this with symbol variations (i.e. adding a syringe symbol to existing symbols for doctors/clinics etc.) I am not saying that this would necessarily work well in this style but it could be worth trying out (also potentially for other medical specialities of course). |
I've intentionally added half-pixel gaps to some icons and one-pixel gaps to others to compare and select the best elements. |
In principle yes. But that is delicate work to design with non-misleading semantics. It would need to be clear that the added syringe indicates a subtype of the symbol without it. We have something like that for different kinds of parking ('P' symbol plus additional symbol) but this would be more difficult for healthcare symbols, in particular because of #3613 and because current healthcare symbols here use a Swiss coat of arms/negative space symbol rather than an actual red cross. |
@StyXman could you update this PR with the new symbol and address the previous comment about line 2552? Now used 700 times, probably not going away anytime soon. |
Closing as stale. If you're still interested in this, feel free to open a new PR addressing the above comments. |
Fixes #4295.
Changes proposed in this pull request:
healtcare=vaccination_centre
Test rendering with links to the example places:
https://www.openstreetmap.org/#map=15/51.5566/-0.2794
Before
After:
The
vaccination_centre
is just north of the Wembley Stadium.