Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render vaccination_centres. #4300

Closed
wants to merge 1 commit into from

Conversation

StyXman
Copy link
Contributor

@StyXman StyXman commented Jan 27, 2021

Fixes #4295.

Changes proposed in this pull request:

  • add healtcare=vaccination_centre

Test rendering with links to the example places:

https://www.openstreetmap.org/#map=15/51.5566/-0.2794

Before
Screenshot_20210127_153709

After:
Screenshot_20210127_153623

The vaccination_centre is just north of the Wembley Stadium.

@StyXman
Copy link
Contributor Author

StyXman commented Jan 27, 2021

The icon is a 10px hospital one, as I couldn't find any that looked like a syringe :)

@polarbearing
Copy link
Contributor

We cannot re-use the hospital icon while telling mappers not to tag the vacc-centres as hospital.
Works neither cartographically nor as mapper feedback.
Icons usually have to be created, not found.

@imagico
Copy link
Collaborator

imagico commented Jan 27, 2021

Thanks for the submission - code looks fine, although i have not tested it.

Right now i see the following problems with this:

  • Use of the tag is not very widespread so far - about a hundred compared to >500 for healthcare:speciality=vaccination. We should not push for a newly created tag and instead wait until it is clear if said tag finds broad support from the community (which is likely here but not guaranteed).
  • Many of the places tagged with this seem not open to the general public but only accessible with an appointment you get subject to varying conditions. So far however taggings indicating such things are not widely used. Indiscriminately showing vaccination centers without indicating if these are open to the general public would limit usefulness of rendering to the map user.
  • A distinct and intuitively readable symbol is an absolute necessity for adding rendering. If a smaller version of an existing symbol is used (and i don't think that is a good idea here) it would need to be adjusted to good quality rendering at the target size.
  • As with other POI rendering suggestions an overall concept of symbology in the domain in question (here: medical/healthcare facilities) that the symbol fits in here should be a prerequisite. At hoc, compartmentalized additions of individual symbols are not a good idea - see Too many icons #3635. In this case specifically the question that would need to be considered is should we decide to render vaccination centers if we should also render vaccination opportunities at places other than dedicated vaccination centers (i.e. healthcare:speciality=vaccination or vaccination=* as addon tags for other medical facilities). Not doing so could very well create counterproductive mapping incentives (i.e. people adding healtcare=vaccination_centre to indicate a vaccination opportunity that is not a dedicated vaccination center).

@StyXman
Copy link
Contributor Author

StyXman commented Jan 27, 2021

This tag has been approved recently: https://wiki.openstreetmap.org/wiki/Proposed_features/Tag:healthcare%3Dvaccination_centre

Use of the tag is not very widespread so far - about a hundred compared to >500 for healthcare:speciality=vaccination

Let's use that one too, then.

Many of the places tagged with this seem not open to the general public but only accessible with an appointment you get subject to varying conditions. So far however taggings indicating such things are not widely used. Indiscriminately showing vaccination centers without indicating if these are open to the general public would limit usefulness of rendering to the map user.

Let's narrow down the filters then. Any suggestions?

A distinct and intuitively readable symbol is an absolute necessity

Yeah, I put the hospital icon just to prove the SQL query works. Does anyone know a syringe icon somewhere? I will try to find one myself, but my time is quite limited.

@polarbearing
Copy link
Contributor

It's unlikely to find an icon matching the requirements here, which is a 14px-optimised monochrome svg.
I'd imagine a syrringe can be drawn as a T for the handle, a rectangle and a thin line, diagonally. Will see if I find time to try.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 29, 2021

While I was personally involved in creating this tag, I don’t think it is well established enough to render right now, considering that we don’t render more common tags like healthcare=laboratory.

However, it would be worth considering adding rendering along with a few of the most common healthcare=* tags once it is more common - see https://wiki.openstreetmap.org/wiki/Template:Map_Features:healthcare

Perhaps we could use a generic, abstract icon such as a filled circle, rather than creating new icons for each feature?

See also #3635 for discussion about the abundance of icons in this style.

Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently would not render the names of healthcare=vaccination_centre features. That would require adding this to line 2552:

[feature = 'healthcare_yes'] {
- and as mentioned the icon needs to be changed

@@ -593,6 +593,13 @@
marker-clip: false;
}

[feature = 'healthcare_vaccination_centre'][zoom >= 15] {
marker-file: url('symbols/amenity/hospital.svg');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symbol needs to be changed, as discussed, either to a generic icon which can be used for a number of healthcare features which are currently not yet rendered (e.g. laboratories, test centres, birth centres, midwives, nurses, chiropractors, acupuncture, etc) or a unique symbol needs to be created which is recognizable, e.g. a syringe.

@enzet
Copy link
Contributor

enzet commented Jun 25, 2021

Here are some sketches of 14 × 14 px icon:

syringe_1

The same × 4:

syringe_4

Any thoughts? What is better: more detailed, more pixel-perfect?

@imagico
Copy link
Collaborator

imagico commented Jun 26, 2021

Those look very good. The other issues mentioned in #4300 (comment) still apply of course. Considering as mentioned vaccination opportunities are often tagged with addon tags (healthcare:speciality=vaccination, vaccination=*) to various medical facilities it could be worth trying to indicate this with symbol variations (i.e. adding a syringe symbol to existing symbols for doctors/clinics etc.) I am not saying that this would necessarily work well in this style but it could be worth trying out (also potentially for other medical specialities of course).

@enzet
Copy link
Contributor

enzet commented Jun 26, 2021

it could be worth trying to indicate this with symbol variations (i.e. adding a syringe symbol to existing symbols for doctors/clinics etc.)

Sorry, not sure I got you right. Do you mean something like that?

syringe_cross

@pnorman
Copy link
Collaborator

pnorman commented Jun 26, 2021

Scaled to 8x
image
Numbering from the top-left and going across, the first three should all have a one pixel gap like the ones below.
Four and eight are quite blurry because they're angled.

@enzet
Copy link
Contributor

enzet commented Jun 26, 2021

the first three should all have a one pixel gap like the ones below

I've intentionally added half-pixel gaps to some icons and one-pixel gaps to others to compare and select the best elements.

@imagico
Copy link
Collaborator

imagico commented Jun 26, 2021

Sorry, not sure I got you right. Do you mean something like that?

In principle yes. But that is delicate work to design with non-misleading semantics. It would need to be clear that the added syringe indicates a subtype of the symbol without it. We have something like that for different kinds of parking ('P' symbol plus additional symbol) but this would be more difficult for healthcare symbols, in particular because of #3613 and because current healthcare symbols here use a Swiss coat of arms/negative space symbol rather than an actual red cross.

@enzet
Copy link
Contributor

enzet commented Jun 26, 2021

Well, I realized that the syringe shape wasn't right. I also changed the needle shape. There are updated and rearranged sketches:

syringe_2

× 4:

syringe_2_x4

For references:

  • without gaps: 2.1 — 2.4,
  • with half-pixel gaps: 2.5 — 2.8,
  • with one-pixel gaps: 2.9 — 2.12.

So far I prefer 2.2 cause it's the most recognizable one.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 6, 2022

@StyXman could you update this PR with the new symbol and address the previous comment about line 2552?

Now used 700 times, probably not going away anytime soon.

@pnorman
Copy link
Collaborator

pnorman commented Jun 28, 2022

Closing as stale. If you're still interested in this, feel free to open a new PR addressing the above comments.

@pnorman pnorman closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render Vaccination centers/centres.
6 participants