Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade URLs #4570

Merged
merged 9 commits into from
Jun 11, 2022
Merged

Conversation

danieldegroot2
Copy link
Contributor

@danieldegroot2 danieldegroot2 commented Jun 7, 2022

Fixes minor issues with URLs. See commit descriptions for additional notes. furthermore, see #2341 ).

Fixes #4253, though this PR is not focused on changing links in comment lines; can be done seperately (usually unmaintained).

See also

Fixed small inconsistencies in URLs.
Fixed small inconsistencies in URLs. Left workflow link as-is.
Fixed some small inconsistencies in URLs and updated all disfunctional links. Note, you may want to update the link for the database setup guide to [a newer version of Ubuntu](https://wiki.ubuntu.com/Releases).
Fixed some small inconsistencies in URLs and simplified reference links which are only called once.

Alternatively, you may use the tile usage policy link between the parentheses instead of the tiles 'link'.
"`OSMF tileservers ([Tile Usage Policy](https://operations.osmfoundation.org/policies/tiles/))`"

For Mapnik (XML) stylesheets, also the link "`[Community list of Mapnik stylesheets](https://github.com/mapnik/mapnik/wiki/StyleShare)`" could be added.
( from https://wiki.openstreetmap.org/wiki/Stylesheets )
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 7, 2022

Thank you for this PR, @danieldegroot2 - many of these links needed to be updated.

@jeisenbe jeisenbe dismissed their stale review June 8, 2022 01:06

Changes not needed

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 8, 2022

I’m not certain, is it better to keep the full version: https://github.com/gravitystorm/openstreetmap-carto/labels/good%20first%20issue and https://github.com/gravitystorm/openstreetmap-carto/issues/711 as links in CONTRIBUTING.md so that they can be copied and pasted or clicked if downloaded to local disc, or should we use the shorter verions e.g. (issues/711) recommended for github?

@danieldegroot2 danieldegroot2 requested a review from jeisenbe June 9, 2022 21:03
RELEASES.md Outdated Show resolved Hide resolved
@danieldegroot2 danieldegroot2 marked this pull request as draft June 10, 2022 18:45
@danieldegroot2 danieldegroot2 marked this pull request as ready for review June 10, 2022 19:07
@danieldegroot2 danieldegroot2 requested a review from pnorman June 10, 2022 19:07
Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@pnorman pnorman merged commit df725e4 into gravitystorm:master Jun 11, 2022
@jeisenbe
Copy link
Collaborator

@danieldegroot2 thank you for this first time PR, much appreciated!

@danieldegroot2 danieldegroot2 deleted the cleanup/upgrade-url branch June 11, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead link to osm2pgsql LUA transforms on main page of repository
4 participants