Require feature check when checking for mall #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, CartoCSS has to check for mall on all non-shop features, a significant combinatorial explosion.
|
There might be changes to objects tagged with tags like |
|
Pinging for PR review. |
imagico
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3759 + previous PRs changed the text-points feature=shop_mall into feature=shop shop=mall. This was done incorrectly in one place where the [feature='shop'] condition was not added, leading to having to check for shop=mall on everything else in the layer, even if it didn't have feature=shop.
This change brings compilation time from 9s to 6.5s and the text-point layer from 2.3s to 1.1s. The total XML decreases from 46670 to 45404 lines.
ref #1941