better way to enable/disable ANSI escape codes in messages #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
natmaka
commented
Jul 5, 2022
natmaka
commented
- better logcheck rules
- minor fixes/enhancements to the documentation
…-sync-daemon.in and psd.service: no ANSI escapes when logging
|
Can you squash into a single commit please |
|
I don't know how to squash (I tried, it fails, and I have no interest in exploring git), sorry |
Leave the first line as-is |
Users cannot delete a root-owned index directory unless it's empty/fixes graysky2#285
This is required to share the synced profiles with flatpak executables. $XDG_RUNTIME_DIR can't be shared, but specified directories inside it can, allowing flatpak-ed browsers to use psd. Keeps $PID_FILE in the same location for compatibility purposes.
This trailing slash prevents `psd` to form a proper dir-name for backup/overlay, so `psd` does not work properly with `surf`, issuing the message: `stat: cannot statx '~/.surf/-backup': No such file or directory`. `surf` keeps its config in "~/.surf". Before this fix, the resulting backup dir is "~/.surf/-backup", not "~/.surf-backup" as it should be. This means that `psd` tries to create a backup inside the dir which it supposed to make backup of. :) After removing this unfortunate '/', `psd` works with `surf` correctly, making proper dirs: '~/.surf-backup' and '~/.surf-back-ovfs'. | sync target: /home/elf/.surf | tmpfs dir: /run/user/1000/elf-surf Note, that none of other browser's configs (in "/usr/share/psd/browsers/*") contains such trailing '/'. Thanks for you work on this Daemon! : )
|
I 'squashed' as required, is it OK? |
|
There are still 34 commits in your PR: |
|
It failed again:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.