Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow driver to be considered ok even if only update_rpm is added #368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infnorm
Copy link
Contributor

@infnorm infnorm commented Sep 16, 2023

Not sure if this is correct, but the simulator for example only initializes update_rpm with certain flag settings.
There seem to be places where update_pwm and update_rpm are checked independently @terjeio?

Not sure if this is correct, but the simulator for example only
initializes update_rpm with certain flag settings.
@terjeio
Copy link
Contributor

terjeio commented Oct 2, 2023

A better test would be spindle->get_pwm ? (spindle->update_pwm != NULL) : (spindle->update_rpm != NULL)?
For now I have solved the issue by instantiating the null spindle in the simulator driver, I'll revisit this a bit later as I will be looking into adding support for stepper driven spindles and completing multiple simultaneously active spindles handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants