Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List table names action v1 #468

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

TrangPham
Copy link
Contributor

No description provided.

@TrangPham TrangPham marked this pull request as ready for review October 3, 2024 21:32
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1-unit-tests@5796392). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##             v1-unit-tests     #468   +/-   ##
================================================
  Coverage                 ?   87.78%           
================================================
  Files                    ?       23           
  Lines                    ?      966           
  Branches                 ?        0           
================================================
  Hits                     ?      848           
  Misses                   ?      118           
  Partials                 ?        0           
Flag Coverage Δ
3.10 73.70% <100.00%> (?)
3.11 73.70% <100.00%> (?)
3.9 73.54% <100.00%> (?)
integration 69.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

)
if response.status_code != 204: # noqa: PLR2004
if response.status_code != 200: # noqa: PLR2004
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@TrangPham TrangPham merged commit b944101 into v1-unit-tests Oct 7, 2024
17 checks passed
@TrangPham TrangPham deleted the list-table-names-action-v1 branch October 7, 2024 20:56
TrangPham added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Joshua Stauffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants