-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add user agent string #672
base: main
Are you sure you want to change the base?
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@@ -156,7 +156,9 @@ def __init__(self: Self): | |||
with warnings.catch_warnings(): | |||
# suppress warnings about GX version | |||
warnings.filterwarnings("ignore", message="You are using great_expectations version") | |||
self._context: CloudDataContext = get_context(cloud_mode=True) | |||
self._context: CloudDataContext = get_context( | |||
cloud_mode=True, user_agent_str="gx-agent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classic bikeshedding on a one-line PR. The intended format (copied from the PR that added the value) is user_agent_str: Optional string, should be of format <PRODUCT> / <VERSION> <COMMENT>
where comment is optional. Can we do user_agent_str=f"gx-agent / {__version__}"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting an update to the form of the agent str
GX Core has recently added functionality which allows us to specify the the run environment for analytics. This PR updates the agent to use it.