-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Unpin snowflake-sqlalchemy
#10838
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,4 +1,4 @@ | |||
pandas<2.2.0; python_version >= "3.9" | |||
snowflake-connector-python>=2.5.0; python_version < "3.11" | |||
snowflake-connector-python>2.9.0; python_version >= "3.11" # earlier versions fail to build on 3.11 | |||
snowflake-sqlalchemy>=1.2.3,<1.7.0 # pinned due to breaking in 1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They didn't yank the broken version
❌ 20 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@@ -86,7 +86,7 @@ def test_queryable_asset_should_pass_test_connection( | |||
) | |||
|
|||
inspector: Inspector = sa.inspection.inspect(snowflake_ds.get_engine()) | |||
inspector_tables = inspector.get_table_names() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This call started returning dict_keys
instead of list
. We only call it in tests. Open issue here: snowflakedb/snowflake-sqlalchemy#566
…eat-expectations/great_expectations into m/core-680/unpin-snowflake-sqlalchemy
@@ -21,11 +21,14 @@ | |||
|
|||
@pytest.mark.snowflake | |||
class TestSnowflake: | |||
@pytest.mark.xfail( | |||
raises=sa.exc.ProgrammingError | |||
) # inspector.get_table_names() fails with this role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into how to reproduce this for a snowflake-sqlalchemy
GH issue, but in the meantime xfailing this test allows us to un-pin.
Unpin
snowflake-sqlalchemy
They didn't yank the broken version (1.7.0), so we just exclude it.
There are some other breaking changes, but they only affect tests in a meaningful way.
invoke lint
(usesruff format
+ruff check
)