Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add MINORBUMP title tag. #10841

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+10 −3
Open

[MAINTENANCE] Add MINORBUMP title tag. #10841

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a369e9
Add MINORBUMP title tag.
billdirks Jan 10, 2025
601274f
Remove errant double quote.
billdirks Jan 10, 2025
aa747ea
Merge branch 'develop' into m/_/add-minorbump-title-tag
billdirks Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


- [ ] Description of PR changes above includes a link to [an existing GitHub issue](https://github.com/great-expectations/great_expectations/issues)
- [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
- [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB], [MINORBUMP]
- [ ] Code is linted - run `invoke lint` (uses `ruff format` + `ruff check`)
- [ ] Appropriate tests and docs have been updated

Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/pr-title-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check PR title validity
if: "!contains(github.event.pull_request.title, '[FEATURE]') && !contains(github.event.pull_request.title, '[BUGFIX]') && !contains(github.event.pull_request.title, '[DOCS]') && !contains(github.event.pull_request.title, '[MAINTENANCE]') && !contains(github.event.pull_request.title, '[CONTRIB]') && !contains(github.event.pull_request.title, '[RELEASE]')"
if: >-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was getting long so I reformatted. I have verified that the title checker still runs and works.

!contains(github.event.pull_request.title, '[FEATURE]') &&
!contains(github.event.pull_request.title, '[BUGFIX]') &&
!contains(github.event.pull_request.title, '[DOCS]') &&
!contains(github.event.pull_request.title, '[MAINTENANCE]') &&
!contains(github.event.pull_request.title, '[CONTRIB]') &&
!contains(github.event.pull_request.title, '[MINORBUMP]') &&
!contains(github.event.pull_request.title, '[RELEASE]')
run: |
echo "Invalid PR title - please prefix with one of: [FEATURE] | [BUGFIX] | [DOCS] | [MAINTENANCE] | [CONTRIB] | [RELEASE]"
echo "Invalid PR title - please prefix with one of: [FEATURE] | [BUGFIX] | [DOCS] | [MAINTENANCE] | [CONTRIB] | [MINORBUMP] | [RELEASE]"
exit 1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading