Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adding keys to duplicated headers #10846

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

deborahniesz
Copy link
Contributor

@deborahniesz deborahniesz commented Jan 10, 2025

Jira Ticket

Deploy Preview

Description

Added specific ID's to duplicated titles in h2 and h3 anchors to avoid the following problem:


repeated headers result in duplicate IDs which make anchors not work as expected

Steps to reproduce:

Go to Connect to SQL data | Great Expectations

Under "Create a Data Asset", next to "Procedure", click the # direct link

Observe that this jumps you up to the "Procedure" section that's nested under "configure credentials" instead of keeping you at the "Procedure" section that's nested under "Create a Data Asset"


  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 879e151
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/678811ee0a53ff00084e98e9

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (1220a18) to head (879e151).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10846   +/-   ##
========================================
  Coverage    80.69%   80.69%           
========================================
  Files          465      465           
  Lines        40493    40493           
========================================
  Hits         32676    32676           
  Misses        7817     7817           
Flag Coverage Δ
3.10 69.99% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 69.99% <ø> (-0.02%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 70.00% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (ø)
3.12 aws_deps 46.24% <ø> (ø)
3.12 big 54.75% <ø> (ø)
3.12 bigquery 48.52% <ø> (ø)
3.12 databricks 50.29% <ø> (ø)
3.12 filesystem 62.74% <ø> (ø)
3.12 mssql 51.29% <ø> (ø)
3.12 mysql 51.70% <ø> (ø)
3.12 postgresql 54.34% <ø> (ø)
3.12 snowflake 51.11% <ø> (ø)
3.12 spark 57.68% <ø> (ø)
3.12 spark_connect 46.53% <ø> (ø)
3.12 trino 52.25% <ø> (ø)
3.9 70.03% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (ø)
3.9 aws_deps 46.26% <ø> (ø)
3.9 big 54.76% <ø> (ø)
3.9 bigquery 48.52% <ø> (ø)
3.9 clickhouse 43.15% <ø> (ø)
3.9 databricks 50.29% <ø> (ø)
3.9 filesystem 62.74% <ø> (ø)
3.9 mssql 51.27% <ø> (ø)
3.9 mysql 51.68% <ø> (ø)
3.9 postgresql 54.33% <ø> (ø)
3.9 snowflake 51.11% <ø> (ø)
3.9 spark 57.64% <ø> (ø)
3.9 spark_connect 46.54% <ø> (ø)
3.9 trino 52.23% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.90% <ø> (ø)
docs-creds-needed 52.85% <ø> (ø)
docs-spark 52.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahniesz deborahniesz force-pushed the DOC-914_deleting_duplicate_IDs_in_anchors branch from 118c706 to cc35b32 Compare January 13, 2025 15:02
@deborahniesz deborahniesz changed the title DOC-914: Adding keys to duplicated headers [DOCS] Adding keys to duplicated headers Jan 13, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@deborahniesz deborahniesz force-pushed the DOC-914_deleting_duplicate_IDs_in_anchors branch from fb6e61b to 879e151 Compare January 15, 2025 19:52
@deborahniesz deborahniesz added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@deborahniesz deborahniesz added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants