-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adding keys to duplicated headers #10846
Open
deborahniesz
wants to merge
2
commits into
develop
Choose a base branch
from
DOC-914_deleting_duplicate_IDs_in_anchors
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+90
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10846 +/- ##
========================================
Coverage 80.69% 80.69%
========================================
Files 465 465
Lines 40493 40493
========================================
Hits 32676 32676
Misses 7817 7817 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deborahniesz
force-pushed
the
DOC-914_deleting_duplicate_IDs_in_anchors
branch
from
January 13, 2025 15:02
118c706
to
cc35b32
Compare
josectobar
approved these changes
Jan 13, 2025
deborahniesz
changed the title
DOC-914: Adding keys to duplicated headers
[DOCS] Adding keys to duplicated headers
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 14, 2025
deborahniesz
force-pushed
the
DOC-914_deleting_duplicate_IDs_in_anchors
branch
from
January 15, 2025 19:52
fb6e61b
to
879e151
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Deploy Preview
Description
Added specific ID's to duplicated titles in h2 and h3 anchors to avoid the following problem:
repeated headers result in duplicate IDs which make anchors not work as expected
Steps to reproduce:
Go to Connect to SQL data | Great Expectations
Under "Create a Data Asset", next to "Procedure", click the # direct link
Observe that this jumps you up to the "Procedure" section that's nested under "configure credentials" instead of keeping you at the "Procedure" section that's nested under "Create a Data Asset"
invoke lint
(usesruff format
+ruff check
)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!