feat(DateTimeControl): Add DateTimeControl to default renderers #102
Conversation
package.json
Outdated
There was a problem hiding this comment.
Antd uses dayjs under the hood, but in order to coerce initial values from string to dayjs format we need to import dayjs into this component to parse the string.
src/antd/InputNumber.tsx
Outdated
There was a problem hiding this comment.
this type was declared but unused inside this component.
There was a problem hiding this comment.
adding format optionally here allows us to distinguish between normal strings and date-time strings.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 74.80% 77.11% +2.30%
==========================================
Files 38 40 +2
Lines 504 533 +29
Branches 96 102 +6
==========================================
+ Hits 377 411 +34
+ Misses 90 83 -7
- Partials 37 39 +2 ☔ View full report in Codecov by Sentry. |
ashmortar
force-pushed
the
f/PH-1604/add-datetime-control
branch
from
6f62186 to
5db15e4
Compare
ashmortar
requested review from
NathanFarmer,
DrewHoo,
lockettks,
dctalbot and
josectobar
ashmortar
force-pushed
the
f/PH-1604/add-datetime-control
branch
from
5db15e4 to
33ff832
Compare
| ? U extends "object" // ObjectControlOptions goes here | ||
| ? unknown | ||
| : U extends "string" | ||
| ? TextControlOptions | ||
| ? F extends "date-time" |
| * can be found in [this section](https://ant.design/components/date-picker#datepicker) | ||
| * of the antd docs. | ||
| */ | ||
| export const allowedDateTimePropKeys: (keyof DatePickerProps)[] = [ |
There was a problem hiding this comment.
If antd adds a property to DatePickerProps, this will compile just fine, but uischemas using the new properties will get rejected at runtime by isDateTimeControlOptions.
To facilitate keeping it up to date more easily, you can write a conditional type that evaluates to true if all of the values in DatePickerProps are contained in this array, and to never if some values in DatePickerProps are not contained in this array, and then write a variable assignment with that type, assigning it to true. That way if new values are added, our code won't compile =)
| if (!visible) return null | ||
|
|
||
| const initialValue = | ||
| typeof schema.default === "string" ? dayjs(schema.default) : undefined |
There was a problem hiding this comment.
Using our own instance of dayjs isn't ideal (or even using a hardcoded timezone library since AntD lets you generate time-based ui controls with your own library) and may cause problems in any app that has a configurable timezone, but I think it's ok for us to use it here since AntD does a pretty poor job making the timezone configurable (it doesn't, and it overrides any default you set on dayjs 😕). If we wanted to support configurable timezones, we'd have to use the generatePicker function and probably accept a datetimelibraryconfig object (inside of jsonforms's config) that contains library-specific details that we could use to generate the AntD DateTime component.
ant-design/ant-design#47490 (comment)
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
date-timewith a priorty of3.uiSchema.optionsinterface typed via updating the existing option type helper.