fix(DefaultExport): export InputNumber and Slider to allow customization #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 77.65% 77.65%
=======================================
Files 40 40
Lines 546 546
Branches 104 104
=======================================
Hits 424 424
Misses 83 83
Partials 39 39 ☔ View full report in Codecov by Sentry. |
shiplet
requested review from
TrangPham,
anthonyburdi,
Shinnnyshinshin and
alena-hutchinson
anthonyburdi
approved these changes
Jan 10, 2025
|
🎉 This PR is included in version 1.22.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NumericSliderControlcomponent uses bothInputNumberandSliderwith fixed column values, but there may be cases where we want the Input/Slider to have different width properties.The
NumericSliderControlis easy enough to mask with a custom renderer in downstream codebases, but the functionality embedded withinInputNumberandSlideris less so. This makes it possible to customize those components' layouts without mucking around too much with types & configs.