Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions for release branches #305

Merged
merged 6 commits into from
May 11, 2021

Conversation

SabineHaas
Copy link
Collaborator

@SabineHaas SabineHaas commented May 7, 2021

Address #297

Note that this fix can only be tested with the next release, see todo in #304

Changes proposed in this pull request:

  • In github actions workflow, add release branches to push events and correct name of dev branch
  • In github actions workflow, set EXECUTE_TEST_ON to "master" for release branches

The following steps were realized, as well (required):

  • Update the CHANGELOG.md
  • Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)

Also the following steps were realized (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code

Please mark above checkboxes as following:

  • Open
  • Done

In case of an error due to linting, run black . --exclude docs/ and push your changes.
Note that in case you do not fix a whole issue you should start your PR with Address #xyz.

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas SabineHaas self-assigned this May 7, 2021
@SabineHaas SabineHaas requested review from MaGering and Piranias and removed request for MaGering May 7, 2021 09:31
@SabineHaas SabineHaas removed the request for review from Piranias May 7, 2021 09:55
@SabineHaas SabineHaas force-pushed the fix/github_actions_for_release_branches branch from 93505a6 to d17a3d6 Compare May 7, 2021 10:44
@SabineHaas SabineHaas requested a review from Piranias May 7, 2021 10:45
@SabineHaas SabineHaas merged commit 5f87f97 into dev May 11, 2021
@SabineHaas SabineHaas deleted the fix/github_actions_for_release_branches branch May 11, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants