Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Drop lcov development dependency in gvmd install instructions #554

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Feb 18, 2025

What

From https://packages.debian.org/bookworm/lcov:

Summarise Code coverage information from GCOV

LCOV is an extension of GCOV, a GNU tool which provides information about what parts of a program are actually executed (i.e. "covered") while running a particular test case.

Installing this development dependency would install a huge amount of unnecessary dependencies (currently for my Debian testing system, might be even more on other "more clean" systems):

Summary:
  Upgrading: 0, Installing: 53, Removing: 0, Not Upgrading: 0
  Download size: 5.057 kB
  Space needed: 38,1 MB / 2.276 MB available

but none of the gvmd docs indicates that this is required / mandatory:

https://github.com/search?q=repo%3Agreenbone%2Fgvmd%20lcov&type=code

Could be even possible to drop the remaining parts on the gvmd repo as well if i understand greenbone/gvmd#1740 correctly.

Why

Don't include unnecessary dependencies in the docs.

References

None

Checklist

@cfi-gb cfi-gb requested a review from a team as a code owner February 18, 2025 13:37
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f222d12.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@greenbonebot greenbonebot enabled auto-merge (rebase) February 18, 2025 13:37
@greenbonebot greenbonebot merged commit 5d27f9d into main Feb 18, 2025
4 checks passed
@greenbonebot greenbonebot deleted the cfi-gb/rm_deps branch February 18, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants