-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border radius feature to core/image #1871
base: main
Are you sure you want to change the base?
Conversation
- Doing this, we'll be able to remove custom classes for borders like ".rounded-90"
/unhold c88a0720-f144-41cd-a315-55f2561360b0
Test instance is ready 🚀🌑 mars | admin | blocks report | CircleCI | composer-local.json ⌚ 2023.01.13 21:21:01 |
/unhold 1c267d5b-053d-483e-bc23-bfe4d1f9f265
/unhold 439bf3aa-7f05-4ad9-8477-73e8fb5b6f5a
/unhold 6cf21cb6-c0fe-4590-a8f4-a579064cdefa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will solve the border-radius issue, but the classes were also added to force the size of the images, I guess we would need to add a class for each size like the w-40
one you added for the Issues template?
Correct me if I see correctly your point! We wouldn't need to add custom class for |
/unhold 9dde0dff-d8b7-448c-899f-607b59392dc4
By Doing this we'll be able to potentially remove some custom classes for borders from here.
and
What to do?