-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7645: Implement image replacement feature #2410
Draft
mardelnet
wants to merge
10
commits into
main
Choose a base branch
from
PLANET-7564_media-replacement-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+269
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add basic implementation
- Add ajax call for the replacement
- Upload file from computer
- Separate JS logic in a different file
- Replace videos
- Purge cloudflare
- Replace elements by name
- Code refactor and cleanup
- Add function docs
- Fix lint issues
mardelnet
force-pushed
the
PLANET-7564_media-replacement-feature
branch
from
October 16, 2024 11:33
9402e8d
to
0eda77b
Compare
planet-4
added a commit
to greenpeace/planet4-test-pandora
that referenced
this pull request
Oct 16, 2024
/unhold 12a5a81e-db53-4701-8798-b331dbc80589
Test instance is ready 🚀🌑 pandora | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.10.16 11:43:24 |
mardelnet
changed the title
PLANET-7564: Implement media replacement feature (part 1)
PLANET-7564: Implement media replacement feature (part 2)
Oct 21, 2024
mardelnet
changed the title
PLANET-7564: Implement media replacement feature (part 2)
PLANET-7654: Implement image replacement feature
Oct 23, 2024
mardelnet
changed the title
PLANET-7654: Implement image replacement feature
PLANET-7645: Implement image replacement feature
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-7645
DESCRIPTION:
This PR is the first of a series in an attempt to implement a media replacement feature.
This PR replaces images from the Media Library, including the entire set of related images (thumbnail, medium, custom, etc.), while keeping the original files' name ONLY in the
uploads
folder (not in Google Storage yet).TESTING (local env only):
/wp-admin/upload.php
planet4/uploads
folder was replaced.NOTES:
As this task seems complex, I plan to split it into multiple PRs and follow these steps:
uploads
folder (done in this PR).wp-stateless
).