PLANET-7633 Add e2e tests for Audio and Video blocks #2447
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold e33c5660-b2dd-4f5c-918d-97e668b328d3
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold b40aa761-fe2f-4ca5-85c8-c0ca8520ecda
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold 591f4d77-e6b4-4692-b759-6656154f6ea9
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold 20386ca7-d741-4eff-9072-9073f0d82425
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
f2877d2 to
493c024
Compare
mleray
commented
Nov 19, 2024
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold 8ebaf1d8-3a25-4088-9aca-1c7f786a0f5e
mleray
commented
Nov 19, 2024
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 19, 2024
/unhold d9c71cb4-0ab3-4457-8da6-0282ca23d408
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
493c024 to
e9c902d
Compare
mleray
commented
Nov 20, 2024
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 20, 2024
/unhold a05ea08a-d5cc-4831-8f51-f86989720643
planet-4
added a commit
to greenpeace/planet4-test-atlas
that referenced
this pull request
Nov 20, 2024
/unhold 21e4ff24-9279-4086-9e30-d6fc71a52b94
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Nov 20, 2024
/unhold 14b51ed0-1bec-43a1-9121-a70db75935b8
Test instance is ready 🚀🌑 venus | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.10 09:23:30 |
|
@GP-Dan-Tovbein I could use your help here, I figured out that the issue with adding several blocks in a row was the block inserter staying open... But now that I've changed that the test is still flaky and I'm not sure why 🥲 |
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
e9c902d to
02b985a
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Nov 26, 2024
/unhold 7a1221f2-ce60-4000-9096-72f54f43fa8d
mleray
requested review from
a team and
sagarsdeshmukh
and removed request for
a team
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
02b985a to
11be3fd
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Nov 28, 2024
/unhold c385329d-3fb1-4e8a-b0c0-4f310df1ee04
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Nov 29, 2024
/unhold 9d2202f7-442a-4d3a-93cd-238d36ff41c1
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 2, 2024
/unhold d4816e81-bc8f-4ae3-a31a-db71f7bb874b
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
4e1ad12 to
22c784e
Compare
@GP-Dan-Tovbein updated, however I would keep these suggested changes in mind for your PR! I've added comments there to keep track. |
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 3, 2024
/unhold 13a3e04e-a6b6-43f0-9ae3-23f8c14fad1f
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
22c784e to
4d5a1df
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 3, 2024
/unhold bcedc192-14e9-4db1-9bc1-19dafabc1b9b
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 3, 2024
/unhold be272c84-4177-4e7c-8982-8f9cd8c70257
GP-Dan-Tovbein
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Code looks good to me!
Passed the spec on my local
with the current configuration
NVM
planet4-master-theme git:(main) ✗ nvm list
v16.20.2
-> v18.20.4
v20.16.0
v22.6.0
default -> 18 (-> v18.20.4)
iojs -> N/A (default)
unstable -> N/A (default)
node -> stable (-> v22.6.0) (default)
stable -> 22.6 (-> v22.6.0) (default)
lts/* -> lts/jod (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.12 (-> N/A)
lts/fermium -> v14.21.3 (-> N/A)
lts/gallium -> v16.20.2
lts/hydrogen -> v18.20.4
lts/iron -> v20.18.0 (-> N/A)
lts/jod -> v22.11.0 (-> N/A)NPM dependencies
planet4-master-theme git:(main) ✗ npm list
├── @commitlint/[email protected]
├── @greenpeace/[email protected]
├── @playwright/[email protected]
├── @wordpress/[email protected]
├── @wordpress/[email protected]
├── @wordpress/[email protected]
├── @wordpress/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]
|
@GP-Dan-Tovbein The tests pass on my local too, but we'll run into issues in the future if they never pass on CI 😕 |
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 4, 2024
/unhold 3a67f11b-6300-4fe6-acab-b605a39c3a6e
mleray
dismissed
GP-Dan-Tovbein’s stale review
We need to make sure that the tests pass on CI too
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
cd2ad0d to
4ffdf09
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 6, 2024
/unhold e3a4976e-4fc6-4551-85af-c980893c8987
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 6, 2024
/unhold 1ef1a3d2-e9eb-456b-ba64-5c7623b92ad9
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
b253f7c to
ad98001
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 6, 2024
/unhold 376ddc58-1a51-4a1e-87fe-37bee9bc311d
|
I see that we are not the only ones having issues with Webkit and CI, according to this thread, unfortunately Playwright doesn't provide any solution 😕 |
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
ad98001 to
4ffdf09
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 6, 2024
/unhold 8c84f12d-545d-418b-84ab-312d45871c0f
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
2328902 to
6f0c265
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Dec 9, 2024
/unhold e20d8e2d-4197-4345-9d1d-f371933ebd00
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
6f0c265 to
deb8bf2
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Jan 10, 2025
/unhold e6b387c4-ea60-4491-88e7-207c71e27da6
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
deb8bf2 to
fa3387c
Compare
Since we recently enabled these two blocks in all sites, it's good to cover them
mleray
force-pushed
the
audio-video-e2e-tests
branch
from
fa3387c to
a61cf15
Compare
planet-4
added a commit
to greenpeace/planet4-test-venus
that referenced
this pull request
Jan 10, 2025
/unhold fece2908-aa1e-4e58-bcbd-56137067c214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7633