PLANET-7635 Move remaining code from plugin #2483
Open
+1,604
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleray
force-pushed
the
plugin-retirement
branch
from
7bdcdda to
6bb6fea
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold fa41d8a9-8b7d-4dac-a210-1c1beff7f362
mleray
force-pushed
the
plugin-retirement
branch
from
6bb6fea to
6f8692b
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 600b91e4-0af2-4943-8b1f-2efd4982d0ff
mleray
force-pushed
the
plugin-retirement
branch
from
6f8692b to
290f771
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold ba88e203-4e03-4a37-9697-60664f3321cc
mleray
force-pushed
the
plugin-retirement
branch
from
290f771 to
4b216e9
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 21dc9923-08b4-42a2-a8ce-e4c03787cd01
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
a67d320 to
f643e97
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold aefb8362-e8ba-4cf9-a778-05e8a5fe5898
mleray
force-pushed
the
plugin-retirement
branch
from
f643e97 to
0d1ff16
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold e7ca49ea-424a-4b4b-9f0c-187c20179cb4
mleray
force-pushed
the
plugin-retirement
branch
from
0d1ff16 to
0088adb
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold a81dcfe8-f6a4-45dc-9a00-1be5f0489e6f
mleray
force-pushed
the
plugin-retirement
branch
from
0088adb to
239889e
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 15c9f992-8501-459c-bf82-325d11d93fa6
mleray
force-pushed
the
plugin-retirement
branch
from
239889e to
bb5f420
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 122a1fc2-04e1-43df-babe-8e5b3638925c
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
925c4a3 to
447ecf7
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 684c4a03-dbf6-418c-89ec-7999c59fd837
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold b4e119b3-104b-4798-af3b-89778ea1c25b
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold d0ff754a-d777-4fb8-9f3e-9abe12e5ae16
mleray
force-pushed
the
plugin-retirement
branch
from
48c2771 to
ec06f4d
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 7347750d-5a3b-474e-b1e6-ea2b6def96f2
mleray
force-pushed
the
plugin-retirement
branch
from
ec06f4d to
001aaf2
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 7c44179c-eaf0-46cd-8494-5768d7469a80
mardelnet
approved these changes
Jan 20, 2025
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jan 21, 2025
/unhold da668e3e-9b35-4cd2-b78e-ca7e170f41bc
There was a problem hiding this comment.
@mleray I'm leaving some comments but please feel free to modify what you consider neccesary.
|
|
||
| const newTermLabel = | ||
| taxonomy?.labels?.add_new_item ?? | ||
| (slug === 'post_tag' ? __('Add new tag') : __('Add new Term')); |
There was a problem hiding this comment.
Don't we need to add the domain?
There was a problem hiding this comment.
No, because this is copied from a WordPress original file. We should update it though, and there is a ticket for that already!
| (slug === 'post_tag' ? __('Add new tag') : __('Add new Term')); | ||
| const singularName = | ||
| taxonomy?.labels?.singular_name ?? | ||
| (slug === 'post_tag' ? __('Tag') : __('Term')); |
There was a problem hiding this comment.
Don't we need to add the domain?
There was a problem hiding this comment.
No, because this is copied from a WordPress original file. We should update it though, and there is a ticket for that already!
This is in preparation to finally retire it
This was set in the plugin but in the theme we use p4_vars
This is causing issues otherwise
We made some simplifications when migrating the block to the theme that broke this behaviour
We can just add these in the editor overrides
This removes one line of code with an unnecessary variable
This removes a file and some unnecessary code
This was requested by PR feedback
These were really small files so we can directly include the code in editorStyle
Not sure why this function was duplicated there
The slug was incorrect
These used to be in the plugin
This used to be in the plugin
This filter used to be in the plugin
This is no longer used
This was not used
These are minor but do improve the code
mleray
force-pushed
the
plugin-retirement
branch
from
13ad035 to
ed44cc0
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jan 24, 2025
/unhold 83699bc5-c320-4a4a-aed3-e7d87ae89b58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7635
Moved code:
Other changes
p4bk_varsapp.jsNote: the editor validation feature also needs to be moved, it's done in #2470