Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attrs): enable autocomplete for props #39

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

emmanuelchucks
Copy link
Contributor

@emmanuelchucks emmanuelchucks commented Jan 16, 2024

Screenshot 2024-01-16 at 18 41 09

Not sure if we should be omitting className or not. Let me know

Copy link

vercel bot commented Jan 16, 2024

@emmanuelchucks is attempting to deploy a commit to the Argos CI Team on Vercel.

A member of the Team first needs to authorize it.

@gregberge gregberge force-pushed the feat/attrs-autocomplete branch from 440a453 to 2c60f64 Compare January 16, 2024 19:52
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
twc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:53pm

@gregberge
Copy link
Owner

Thanks @emmanuelchucks, I added Record<string, any> because we don't want to enforce this type, just autocomplete it. We are not sure if underlying type is broken or not.

@gregberge gregberge merged commit 9cb840c into gregberge:main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants