refactor protocol position for delegates

grenos · Apr 13, 2020 · 92ea79e · 92ea79e
1 parent c3e239e
commit 92ea79e
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 16 deletions.
diff --git a/...odeproj/project.xcworkspace/xcuserdata/vasilis.xcuserdatad/UserInterfaceState.xcuserstate b/...odeproj/project.xcworkspace/xcuserdata/vasilis.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/GHFollowers/Components/Labels/GFBodyLabel.swift b/GHFollowers/Components/Labels/GFBodyLabel.swift
@@ -30,6 +30,8 @@ class GFBodyLabel: UILabel {
     private func configure () {
         textColor = .secondaryLabel
         font = UIFont.preferredFont(forTextStyle: .body)
+        // For dynamic type text
+        adjustsFontForContentSizeCategory = true
         adjustsFontSizeToFitWidth = true
         minimumScaleFactor = 0.75
         lineBreakMode = .byWordWrapping

diff --git a/GHFollowers/Components/ViewControllers/GFUserInfoheaderVC.swift b/GHFollowers/Components/ViewControllers/GFUserInfoheaderVC.swift
@@ -115,7 +115,7 @@ class GFUserInfoheaderVC: UIViewController {
             bioLabel.topAnchor.constraint(equalTo: avatarImageView.bottomAnchor, constant: textImagePadding),
             bioLabel.leadingAnchor.constraint(equalTo: avatarImageView.leadingAnchor),
             bioLabel.trailingAnchor.constraint(equalTo: view.trailingAnchor),
-            bioLabel.heightAnchor.constraint(equalToConstant: 60)
+            bioLabel.heightAnchor.constraint(equalToConstant: 90)
         ])
     }
 }

diff --git a/GHFollowers/Components/ViewControllers/ItemInfoVCs-SuperClass+SubClass/GFItemInfoVC.swift b/GHFollowers/Components/ViewControllers/ItemInfoVCs-SuperClass+SubClass/GFItemInfoVC.swift
@@ -8,6 +8,14 @@
 
 import UIKit
 
+// setup the protocol for the delegate
+// use :class to be able to set a weak link in memory
+protocol ItemInfoVCDelegate: class {
+    func didTapGithubProfile(for user: User)
+    func didTapGetFollowers(for user: User)
+}
+
+
 class GFItemInfoVC: UIViewController {
 
     let stackView = UIStackView()
@@ -19,7 +27,7 @@ class GFItemInfoVC: UIViewController {
 
     // delegate variables need to be weak
     // to avoid memory leaks
-    weak var delegate: UserInfoVCDelegate!
+    weak var delegate: ItemInfoVCDelegate!
 
 
     // create a custom initializer

diff --git a/GHFollowers/Screens/FollowerListVC.swift b/GHFollowers/Screens/FollowerListVC.swift
@@ -10,12 +10,6 @@ import UIKit
 
 
 
-protocol FollowerListVCDelegate: class {
-    func didRequestFollowers(for username: String)
-}
-
-
-
 class FollowerListVC: GFDataLoadingVC {
 
     // enums are hashable by default
@@ -317,7 +311,7 @@ extension FollowerListVC: UISearchResultsUpdating {
 
 
 // MARK: Delegate
-extension FollowerListVC: FollowerListVCDelegate {
+extension FollowerListVC: UserInfoVCDelegate {
     func didRequestFollowers(for username: String) {
         // get followers for new user
         self.username = username

diff --git a/GHFollowers/Screens/UserInfoVC.swift b/GHFollowers/Screens/UserInfoVC.swift
@@ -8,11 +8,8 @@
 
 import UIKit
 
-// setup the protocol for the delegate
-// use :class to be able to set a weak link in memory
 protocol UserInfoVCDelegate: class {
-    func didTapGithubProfile(for user: User)
-    func didTapGetFollowers(for user: User)
+    func didRequestFollowers(for username: String)
 }
 
 
@@ -27,7 +24,7 @@ class UserInfoVC: UIViewController {
     // username gets passed here from FollowerListVC from function -- extension FollowerListVC: UICollectionViewDelegate --
     var username: String!
 
-    weak var delegate: FollowerListVCDelegate!
+    weak var delegate: UserInfoVCDelegate!
 
     override func viewDidLoad() {
         super.viewDidLoad()
@@ -104,7 +101,7 @@ class UserInfoVC: UIViewController {
 
         NSLayoutConstraint.activate([
             headerView.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor),
-            headerView.heightAnchor.constraint(equalToConstant: 180),
+            headerView.heightAnchor.constraint(equalToConstant: 210),
 
             itemViewOne.topAnchor.constraint(equalTo: headerView.bottomAnchor, constant: padding),
             itemViewOne.heightAnchor.constraint(equalToConstant: 140),
@@ -133,7 +130,7 @@ class UserInfoVC: UIViewController {
 // we set the ItemInfoVC as the delegate
 
 // Conform to the protocol
-extension UserInfoVC: UserInfoVCDelegate {
+extension UserInfoVC: ItemInfoVCDelegate {
     // this function is called in the GFRepoItemVC
     func didTapGithubProfile(for user: User) {
         // show safari view controller