-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project fork plugin id and deployment changes #1
Conversation
* Plugin id org.akhikhl.gretty -> org.gretty. * Changed artifacts group org.akhikhl.gretty -> org.gretty. * Updated developerId. * Added bintrayRepo and bintrayPackage variables to be supplied by Travis as BINTRAY_REPO and BINTRAY_PACKAGE
@henrik242 @boris-petrov @woldie @wolfs PTAL and advise if you can review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. We should probably disable the jdk7 build, though.
Looks good to me. There’s a few pull-requests in the “original” repo that are good to be merged before a new release - there is one for Gradle 4.6 support, I have one for Tomcat 8.5.2+ support. Maybe some of the others too. Thanks for taking the time and initiative to do this!
|
Hey @javabrett! Does this mean you are taking over maintaining the Gretty plugin now? That would be great! What are your plans how to continue with this? If this becomes the "official" fork, the official Gradle documentation should also point to this plugin instead of I also would like to know @akhikhl's thoughts on this fork. |
Ah, I found this discussion. Are there some other discussions going on somewhere? It would be great to get the readme of this repository updated. |
I guess it would be a good idea to make a handful of people admins for this project right away. From personal experience that made the Spotbugs project move forward easily when it forked from Findbugs. |
@javabrett It looks like the issue tracker is missing from this project, could you enable it? |
@henrik242 I had no idea that was off by - default. On now. |
as BINTRAY_REPO and BINTRAY_PACKAGE
Via Travis build (when pushed as
master
) this pushes a snapshot to http://oss.jfrog.org/oss-snapshot-local/org/gretty/gretty/2.0.1-SNAPSHOT/ .Note that you cannot test the actual deployment, as that requires an encrypted keys change which will follow.