Add icon to page header if an account is a contract #348 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansallinen
requested changes
Feb 4, 2025
Comment on lines
+30
to
+38
| <button | ||
| onclick={goToContract} | ||
| class={cn( | ||
| 'peer absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2 focus-visible:outline-none', | ||
| buttonSize | ||
| )} | ||
| > | ||
| <!-- Button is done this way with absolute positioning so we can maintain a decent hit slop on mobile without affecting layout --> | ||
| </button> |
There was a problem hiding this comment.
Navigation should be done with a link (anchor tag) when possible to take advantage of preloading
Comment on lines
+30
to
+38
| <button | ||
| onclick={goToContract} | ||
| class={cn( | ||
| 'peer absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2 focus-visible:outline-none', | ||
| buttonSize | ||
| )} | ||
| > | ||
| <!-- Button is done this way with absolute positioning so we can maintain a decent hit slop on mobile without affecting layout --> | ||
| </button> |
Comment on lines
60
to
68
| {#if routePath === 'account'} | ||
| <CopyButton data={props.title} /> | ||
| <CopyButton data={props.title} slop={false} /> | ||
| {#if props.contract} | ||
| <CodeButton data={contractPath} slop={false} /> | ||
| {/if} | ||
| {/if} | ||
| {#if routePath === 'contract'} | ||
| <AccountButton data={accountPath} slop={false} /> | ||
| {/if} |
There was a problem hiding this comment.
With this layout, the button under the cursor changes depending on the page - we should keep consistency and either add a copy button to the contract page, or swap the order so the switcher button is first.
3 tasks
|
Merged. Opened issue #372 to track the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #348