Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor fix on mapquest and add environment variable to retrieve key #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renewang
Copy link

@renewang renewang commented Nov 5, 2014

I modified get_tweet_json.py:

  1. to allow geocoding as false
  2. to ensure the url sent to mapquest api is encoded.
  3. use list for location dictionary for tweets with duplicate locations
    Also modified tweet_credentials in which the hard-coded api key/secret is replaced by os environment variable.
    Thanks for your time to review this.

@grfiv
Copy link
Owner

grfiv commented Apr 8, 2016

Gosh! I'm sorry I didn't get back to you. Pull requests are a new thing for me and I just noticed.

The screen says

This branch has conflicts that must be resolved
Use the command line to resolve conflicts before continuing.

I'd love to review what you did but I'm afraid I can't. Do you think you could try again?

George

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants