feat: Add support for windows #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix should use conditional compilation with |
Also look for _netrc file in USERPROFILE
You are right, I've updated the pull request. Please review again. |
gribouille
approved these changes
Jun 14, 2024
|
Could you please push a release with this change to crates.io? Thanks in advance! |
This was referenced Oct 16, 2024
charliermarsh
pushed a commit
to astral-sh/uv
that referenced
this pull request
Oct 21, 2024
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Before this PR (and since 651fe6f) `uv` depends on a git snapshot of `rust-netrc` at gribouille/netrc@544f389, with fixes from gribouille/netrc#3 for #8003. Since `rust-netrc` 0.1.2 was just released, and it includes those fixes – plus an additional [change to support `~`-expansion](gribouille/netrc@ca0860c) – `uv` can go back to depending on published crates from crates.io. ## Test Plan <!-- How was it tested? --> ``` $ cargo build $ cargo run python install $ cargo test ``` I get ``` ──────────────────────────────────────────────────────────────────────────────── ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot: sha Source: crates/uv/tests/it/build.rs:1454 ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Expression: snapshot ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── -old snapshot +new results ────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 11 11 │ writing top-level names to src/project.egg-info/top_level.txt 12 12 │ writing manifest file 'src/project.egg-info/SOURCES.txt' 13 13 │ reading manifest file 'src/project.egg-info/SOURCES.txt' 14 14 │ writing manifest file 'src/project.egg-info/SOURCES.txt' 15 │+[CACHE_DIR]/builds-v0/[TMP]/pkg_resources.html 16 │+ import pkg_resources 15 17 │ running sdist 16 18 │ running egg_info 17 19 │ writing src/project.egg-info/PKG-INFO 18 20 │ writing dependency_links to src/project.egg-info/dependency_links.txt ┈┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ 35 37 │ copying src/project.egg-info/top_level.txt -> project-0.1.0/src/project.egg-info 36 38 │ Writing project-0.1.0/setup.cfg 37 39 │ Creating tar archive 38 40 │ removing 'project-0.1.0' (and everything under it) 41 │+[CACHE_DIR]/builds-v0/[TMP]/pkg_resources.html 42 │+ import pkg_resources 39 43 │ Building wheel from source distribution... 40 44 │ running egg_info 41 45 │ writing src/project.egg-info/PKG-INFO 42 46 │ writing dependency_links to src/project.egg-info/dependency_links.txt 43 47 │ writing requirements to src/project.egg-info/requires.txt 44 48 │ writing top-level names to src/project.egg-info/top_level.txt 45 49 │ reading manifest file 'src/project.egg-info/SOURCES.txt' 46 50 │ writing manifest file 'src/project.egg-info/SOURCES.txt' 51 │+[CACHE_DIR]/builds-v0/[TMP]/pkg_resources.html 52 │+ import pkg_resources 47 53 │ running bdist_wheel 48 54 │ running build 49 55 │ running build_py 50 56 │ creating build ┈┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ 73 79 │ adding 'project-0.1.0.dist-info/WHEEL' 74 80 │ adding 'project-0.1.0.dist-info/top_level.txt' 75 81 │ adding 'project-0.1.0.dist-info/RECORD' 76 82 │ removing build/bdist.linux-x86_64/wheel 83 │+[CACHE_DIR]/builds-v0/[TMP]/pkg_resources.html 84 │+ import pkg_resources 77 85 │ Successfully built dist/project-0.1.0.tar.gz and dist/project-0.1.0-py3-none-any.whl ────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── To update snapshots run `cargo insta review` Stopped on the first failure. Run `cargo insta test` to run all snapshots. thread 'build::sha' panicked at /home/ben/.cargo/registry/src/index.crates.io-6f17d22bba15001f/insta-1.40.0/src/runtime.rs:548:9: snapshot assertion for 'sha' failed in line 1454 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: build::sha test result: FAILED. 1299 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out; finished in 101.18s error: test failed, to rerun pass `-p uv --test it` ``` The sole failure looks unrelated to me, and I can reproduce it on `main` (currently e8b8daf), so I conclude that it has nothing to do with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also look for _netrc file in USERPROFILE.
fixes #1 and fixes #2