-
Notifications
You must be signed in to change notification settings - Fork 172
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Gridcoin Research 3.5.8.8/MSI=42.2 Mandatory Upgrade - Resolve syncing problem with beacon business logic.
- Loading branch information
Showing
6 changed files
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the time I have to upgrade to a new mandatory upgrade short, to the point where I am now actively monitoring this github repository to keep up. Also the website does not list the current version or if there has been any update. The only 'media' way to know there is a new mandatory version is 'that one tweet'.
I would suggest trying to find ways to improve the communication of mandatory updates as I expect this may be one of the reasons there are clients staying on old versions.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if once in awhile the client checks for an updated version and makes a popup saying there is a new version or in the mininginfo section? atleast and wheather its mandatory or not. thatd be a little more effective? wheather checking online for a new version number .
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, there should be better mechanism for forcing checks against the current version. Ultimately, the application should be able to present a non-technical user with an easy experience keeping up-to-date.
Maybe just adding a couple strings on the overview, one showing client rev and one showing latest available rev. It could highlight red if client is out of sync? That could help draw people to be more aware of updates.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dantali0n Join the Telegram group if you don't use IRC https://t.me/gridcoin
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grctest Thanks for the suggestion but it's not really about me, we have to look at the grand scheme of things. Organizations like bittrex or eobot running this client, none technical users etc. We can't expect all of them to actively monitor IRC, Telegram or Github in order to be notified of an update. (Bittrex still has GRC 'wallet maintenance')
In my opinion it would be a good idea to spent time and effort into making a release schedule. With this schedule we could communicate mandatory updates way in advance making sure all users are ready to update when the time comes.
In the GUI options of the client there is also this 'automatic update' button which does not seem to work at least not for me. It would be amazing if users there clients would automatically update.
In all fairness I understand that making things like release schedules or implementing automatic updates is hard but it would still be a good idea to look into it.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with above. You have to treat users like fools although obviously, most are not. Education and a strict AUP (Acceptable Use Policy) that contracts the user to taking responsibility for their own actions/inactions is the only way to do it. You need a streamline classy look with hardly any switches or knobs. The less user input the better. Download the Windows wallet for Ethereum and take in the design, ergonomics and function. Have a rant at me, I don't mind. We are getting in a right mess here and the only way is strict structured ways of doing things already proven in Enterprise IT such as ITIL service management. The wallet should update itself. If it needs a reboot then the only input a user should have is to be able to set a preferred reboot window. This should be stated in the AUP and signed for by proxy on downloading the initial exe or msi file.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The wallet should update itself" I don't agree. The user should be notified of release, but he needs to confirm the download and install. Especially on linux, every program that updates or modifies itself is considered a virus (trojan?). There are package managers and market to update your packages. Additionally I am for more knobs, settings and information in the wallet gui (instead of editing config files).
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm referring to Windows only which the majority will be using. If you think more bells and whistles is good for the average Windows user you are a fool yourself. In fact I'd say the average user on any O/S needs simple but powerful GUI. If you are happy to man the support and help channels go for it. If not, then kindly keep your ill-informed opinions to yourself.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dantali0n
Erkan-Yilmaz/Gridcoin-tasks#95
We try to contact all users through multiple social media platforms, but unfortunately not everyone is active enough to take notice. Users should join telegram, follow the twitter account, subscribe to the announcement thread on cryptocointalk, enable release notifications in this repo, etc.
I agree with @tomasbrod that an auto-upgrader goes against what many would deem acceptable, if you want an always up-to-date client you can use tools to automate upgrades.
Normally this would be the case, but these releases were not planned - they were mandatory due to glitches which were/are causing syncing issues and potentially forks. With planned mandatory releases we notify the services/exchanges weeks in advance.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont agree with auto upgrade as that could be dangerous. just a label saying upgrade avaiable on wallet would be good in my opionon. also make it more easier for people to follow the social platform accounts of gridcoin (maybe in about gridcoin window).
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could scrape the latest release from github within the client, rather than looking for version numbers greater than your client within getpeerinfo, that's one way we could introduce an update notification..
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grctest i think from github is a sound idea. only thing i think could be an issue possibly is precompiled can take a little longer to be released versus what is on there immediatly from an update. but i agree with your idea of scrape
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grctest That way we block a potential vulnerability where malicious clients with high version numbers are introduced into the network to trigger update alerts on clients. Sounds like a good idea to use Github as a source for checking the most recent version.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would totally agree if we didn't need the majority of clients at latest mandatory to effect a graceful resolution. Compromise suggests this maybe.... 'only windows X only when a mandatory is issued X only when the mandatory upgrade is to repair a failed engine (eg: not cosmetic or wish list but hardcore repair or fault resolver) X user has agreed to submit to automatic new write-over install versions where the upgrade occurs in a set time window (off-peak local time) X if: the upgrade needs a reboot of client or computer or both to satisfy best-practise, then this action will only occur if the user has agreed to submit to an ungraceful hard reboot (it could be a graceful soft reboot however, best to caveat for last-resort scenario)
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also: important info to be displayed in the wallet (message of the day, ...)
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we try to push update notification to our users, we should also point them to the download. For example I did not see a link from this GitHub to the official Windows installer or Linux deb. And when I download from gridcoin.us it is not clear what wersion msi I am downloading (I can't verify from linux that link that i give to my win friend is really the latest).
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify myself for @philipswift: I agree with you that simple gui is much better than complex one like in the first picture.
But for being forced to edit config files is even worse then that. The gui has to provide access to important information and allow changing settings that every user needs to adjust (like the email). I believe we can agree on that. No h8 m8 :)
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not your mate.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're talking about possible vectors of attack etc, i'm sort of uncomfortable with there being a fully-realized boincstats.com inside the wallet. being somebody that uses a shitload of ad-blocker and data-collection circumventing software, this feels problematic to me.
i would much rather have our IRC in there or something... is there a way to add a simple chat client to the wallet? would be easier to give support for new versions also. people would already see chatter going on about whether or not to update in the same window.
63547b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This chat could even be done decentralized. I mean reuse the gossip mechanism used for transaction propagation to propagate chat messages. Very easy to spam though. Other way: IRC is already implemented (to some degree) in wallet for testnet peer discovery.
Apart from the boincstats browser window, there is a boincstats ekvivalent limited for our teem for the NN. Would be cool if the wallet somehow allow to view the data.
I will now create separate issues from theese ideas. Edit: already done #270