Merge pull request #2723 from div72/sync-nodiscard

refactor: use the try_lock result in TryEnter
gridcoin-community · Dec 10, 2023 · f5aa2b1 · f5aa2b1
2 parents f82e653 + a7a6581
commit f5aa2b1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/sync.h b/src/sync.h
@@ -160,10 +160,11 @@ class SCOPED_LOCKABLE UniqueLock : public Base
     bool TryEnter(const char* pszName, const char* pszFile, int nLine)
     {
         EnterCritical(pszName, pszFile, nLine, (void*)(Base::mutex()), true);
-        Base::try_lock();
-        if (!Base::owns_lock())
-            LeaveCritical();
-        return Base::owns_lock();
+        if (Base::try_lock()) {
+            return true;
+        }
+        LeaveCritical();
+        return false;
     }
 
 public: