Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Turn net structures into dumb storage classes (backport) #2561

Merged
merged 2 commits into from
Dec 2, 2022
Merged

net: Turn net structures into dumb storage classes (backport) #2561

merged 2 commits into from
Dec 2, 2022

Conversation

Pythonix
Copy link
Contributor

@Pythonix Pythonix commented Aug 3, 2022

This is a backport of bitcoin/bitcoin#8128 and bitcoin/bitcoin#7868.

As @jamescowens said in #2558, it probably doesn't make sense to port all the old commits until we finally get to the latest state. However, this backport helps with porting new code because it introduces "netaddress.{cpp,h}" and therefore makes "netbase.{cpp,h}" a bit leaner. This simplifies the backport of newer "netaddress.{cpp,h}" files. Also, tests for addrman have been added and some netbase tests have been updated. For testing I changed the proxy settings and ran the wallet through a proxy and started the wallet with "--proxy".

@Pythonix Pythonix changed the title net: Split DNS resolving functionality out of net structures (backport) net: Turn net structures into dumb storage classes (backport) Aug 3, 2022
@jamescowens jamescowens requested a review from div72 August 3, 2022 16:19
@jamescowens jamescowens added compatibility refactor This is for refactoring (if also an enhancement, use that label too). labels Aug 3, 2022
@jamescowens jamescowens added this to the LaVerne milestone Aug 3, 2022
Copy link
Member

@div72 div72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 402bb7f.

@jamescowens
Copy link
Member

Yep. I will wait to merge this until we do the submilestone point release 5.4.1.0, which will be soon.

@iFoggz
Copy link
Member

iFoggz commented Oct 5, 2022

Nice to see the net code being cleaned up. looking forward to more and connection polling in future. cheers! great work.

@jamescowens jamescowens self-requested a review December 2, 2022 17:16
Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Now that 5.4.1.0 is out of the way I am merging.

@jamescowens jamescowens merged commit b1e43cf into gridcoin-community:development Dec 2, 2022
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Mar 26, 2023
Added
 - key, wallet: HD wallets gridcoin-community#2540 (@div72)
 - ARMv8 SHA2 Intrinsics gridcoin-community#2612 (@barton2526)
 - build: vendor bdb 5.3 gridcoin-community#2620 (@div72)
 - scraper, gui: Add external adapter projects indication gridcoin-community#2625 (@jamescowens)
 - gui: implement INSUFFICIENT_MATURE_FUNDS status for the mrcmodel gridcoin-community#2628 (@jamescowens)
 - gui, accrual: Implement accrual limit warning gridcoin-community#2636 (@jamescowens)
 - rpc: add `getnodeaddresses` gridcoin-community#2646 (@Pythonix)
 - consensus: Add new checkpoints gridcoin-community#2651 (@barton2526)

Changed
 - voting: Optimize poll locks gridcoin-community#2619 (@jamescowens)
 - util: move threadinterrupt.{cpp,h} to util gridcoin-community#2613 (@Pythonix)
 - gui, voting: Update pool cpids and avw rules gridcoin-community#2624 (@jamescowens)
 - ci: bump python and setup-python action version gridcoin-community#2626 (@div72)
 - gui: Change text from username to name (real name or nickname) gridcoin-community#2633 (@jamescowens)
 - locale: Translation update, phase 1 gridcoin-community#2637 (@jamescowens)
 - gui: Change MRC too soon to submit error to be less confusing gridcoin-community#2645 (@jamescowens)
 - locale: Update translations prior to release (phase 2/2) gridcoin-community#2658 (@jamescowens)
 - gui: Enhance MRC request form to avoid fee boost field confusion gridcoin-community#2659 (@jamescowens)

Removed
none

Fixed
 - net: Turn net structures into dumb storage classes (backport) gridcoin-community#2561 (@Pythonix)
 - build: Include native_X.mk before X.mk gridcoin-community#2609 (@barton2526)
 - depends: fix OpenSSL for Darwin builds gridcoin-community#2610 (@div72)
 - build: Change actions runner image to Focal, Force Lint to use 22.04, Change cd runner version gridcoin-community#2611 (@barton2526)
 - gui: don't show datadir error msgbox if arg isn't specified gridcoin-community#2617 (@div72)
 - rpc: Repair auditsnapshotaccrual rpc function gridcoin-community#2621 (@jamescowens)
 - gui: Correct updateBeaconIcon() function in bitcoingui.cpp gridcoin-community#2622 (@jamescowens)
 - wallet: Strengthen CWalletTx::RevalidateTransactions gridcoin-community#2627 (@jamescowens)
 - test: Fix Wambiguous-reversed-operator compiler warning, drop boost::assign gridcoin-community#2632 (@barton2526)
 - gui: Fix wallet overview displaying lower-case poll name gridcoin-community#2640 (@delta1513)
 - Fix and optimize ResendWalletTransactions gridcoin-community#2642 (@jamescowens)
 - build(nsis): Write registry keys to HKLM instead of HKCU, Install shortcuts for all users, Fix INSTALLDIR removal bug gridcoin-community#2643 (@sitiom)
 - gui: Fix TransactionRecord::decomposeTransaction to properly display self-sidestake gridcoin-community#2647 (@jamescowens)
 - rpc: Fixed the RPC error when running `help voting` while syncing gridcoin-community#2649 (@delta1513)
 - build: Fix compilation with GCC 13 gridcoin-community#2653 (@theMarix)
 - rpc: Formatting - typo correction rpc help for listresearcheraccounts gridcoin-community#2654 (@PrestackI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility refactor This is for refactoring (if also an enhancement, use that label too).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants