Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: fix setban segfault #2757

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

div72
Copy link
Member

@div72 div72 commented Apr 4, 2024

Fixes #2750.

Not checking can cause a segfault if LookupHost fails.
@div72 div72 self-assigned this Apr 4, 2024
Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jamescowens jamescowens added this to the Natasha milestone Apr 5, 2024
@jamescowens jamescowens merged commit 7847923 into gridcoin-community:development Apr 5, 2024
21 checks passed
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Apr 10, 2024
Added
 - build: add option for sanitizers gridcoin-community#2553 (@div72)
 - build: CMake: Initial Windows support (MSYS2) gridcoin-community#2733 (@CyberTailor)

Changed
 - build: enforce SSE2 on x86 targets gridcoin-community#2746 (@div72)
 - consensus: Update checkpoint data for mainnet and testnet gridcoin-community#2756 (@jamescowens)
 - gui, util: Enhance verify checkpoints fail handling; use RegistryBookmarks for DB passivation gridcoin-community#2758 (@jamescowens)

Removed

Fixed
 - build, depends: fix compilation with XCode 15 gridcoin-community#2747 (@div72)
 - Fix man page installation path for cmake builds gridcoin-community#2749 (@theMarix)
 - consensus, mrc, sidestake: add mrc fees to staker to rewards to be allocated via sidestaking gridcoin-community#2753 (@jamescowens)
 - Fix Systemd unit install location gridcoin-community#2754 (@theMarix)
 - scraper: Corrections to scraper_net after removal of cntPartsRcvd decrement and increment gridcoin-community#2755 (@jamescowens)
 - rpc: fix setban segfault gridcoin-community#2757 (@div72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setban causes segfault on malformed IP
2 participants