[cmake] bdb53: disable error for implicit-int with gcc #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using -Werror=implicit-int is now default in gcc 14 see: https://gcc.gnu.org/gcc-14/porting_to.html This fixes the following issue: configure:20682: cc -o conftest -O3 -D_GNU_SOURCE -D_REENTRANT conftest.c -lpthread >&5 conftest.c:46:1: error: return type defaults to 'int' [-Wimplicit-int] 46 | main() { | ^~~~ configure:20682: 0 = 1 configure: program exited with status 1 Signed-off-by: Lukas Rusak <[email protected]>
div72
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
utACK - Would you mind adding this to automake side as well?
Gridcoin-Research/configure.ac
Line 1421 in 2c25758
->
- AX_SUBDIRS_CONFIGURE([src/bdb53], [[CFLAGS="-Wno-error=implicit-function-declaration"], [CXXFLAGS="-Wno-error=implicit-function-declaration"], [--disable-java], [--disable-jdbc], [--disable-replication], [--enable-cxx], [$ADDITIONAL_BDB_FLAGS]], [], [], [])
+ AX_SUBDIRS_CONFIGURE([src/bdb53], [[CFLAGS=-Wno-error=implicit-function-declaration -Wno-error=implicit-int], [CXXFLAGS=-Wno-error=implicit-function-declaration -Wno-error=implicit-int], [--disable-java], [--disable-jdbc], [--disable-replication], [--enable-cxx], [$ADDITIONAL_BDB_FLAGS]], [], [], [])
I pushed a fixup to add this. I can remove "cmake" from the commit message if you are happy with the change. |
Sure, you can also keep it as two separate commits. |
|
Can we fix the CI errors please? @div72 this does not look specific to this PR. |
|
@jamescowens Can you cherry-pick 35eccfd? |
|
Ok. |
jamescowens
merged commit a3dafe6
into
gridcoin-community:development
18 of 21 checks passed
wilkart
pushed a commit
to wilkart/Gridcoin-Research
that referenced
this pull request
Jun 29, 2024
[cmake] bdb53: disable error for implicit-int with gcc
jamescowens
added a commit
that referenced
this pull request
Feb 16, 2025
Added - depends: add cross arm64-darwin support #2775 (@div72) - build: add missing randomness checks #2772 (@div72) - init, registry: Support -clearallregistryhistory startup parameter #2773 (@jamescowens) Changed - build: omit _FORTIFY_SOURCE on debug #2793 (@div72) - doc: cmake is required for Windows depends #2791 (@barton2526) - CMake: Set maximum supported Boost version #2788 (@CyberTailor) - ci: bump to MacOS 13 #2784 (@div72) - build/cmake: disable LevelDB tests #2776 (@div72) - util: use XDG_STATE_HOME for datadir on Flatpak #2774 (@div72) - util, build: Support miniupnp API version 18+ #2771 (@jamescowens) - build: explicitly include FindPkgConfig for CMake #2769 (@jamescowens) - ci, cd: bump action versions #2763 (@div72) - Sync CMake CI #2762 (@CyberTailor) - cpid: Modify CPID local hasher to eliminate compiler warnings on 32 bit archs #2760 (@jamescowens) Removed - refactor, misc: remove CBitcoin(Address|Secret) #2634 (@div72) Fixed - poll, gui: Disable choice add button in poll wizard when choice limit is reached #2792 (@jamescowens) - diagnose, rpc: fix compilation with boost 1.87 #2786 (@div72) - node: fix build with GCC 15 #2783 (@CyberTailor) - ci: use overwrite with brew install on MacOS CMake #2782 (@div72) - scraper: Protect access to ConvergedStats.csv.gz with a lock #2779 (@jamescowens) - fix build on FreeBSD #2770 (@wilkart) - rpc/server: fix removing deprecated commands from command list #2768 (@lrusak) - cmake bdb53: disable error for implicit-int with gcc #2767 (@lrusak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that on fedora 40 (using gcc 14),
gridcoinresearchdfails to compile to an implicit-int conversion.This happens in the bdb53 dependency build. I didn't want to change the source code there so I just disabled the error so it would only be a warning. I also only made this change for GNU compiler, I'm not sure if it effects others.
The actual error is in the config.log of bdb53:
This cause the mutex detection to fail and ultimately fail the build. In the actual build log this looks like:
This can be seen in the aarch64 build here -> https://build.opensuse.org/package/live_build_log/home:theMarix/gridcoin/Fedora_40/aarch64
This comes down to the fact that implicit-int was promoted to an error by default in gcc 14
see: https://gcc.gnu.org/gcc-14/porting_to.html