-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: add cross arm64-darwin support #2775
depends: add cross arm64-darwin support #2775
Conversation
@jamescowens What are we building bzip2 in depends for? |
03618ae
to
cbba203
Compare
Probably nothing. I think it came along for the ride with the original depends port.Sent from my iPhoneOn Sep 15, 2024, at 8:05 PM, div72 ***@***.***> wrote:
@jamescowens What are we building bzip2 in depends for?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
0db7cbe
to
b04bd2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Can we get all of the CI jobs working before I merge this?
See bitcoin/bitcoin#22380. GNU flavor is used for the C standard as OpenSSL have troubles building without it.
Needed for cross arm64-apple-darwin builds.
Needed now since FORCE_USE_SYSTEM_CLANG is removed and system clang is mandatory.
See bitcoin/bitcoin#7f5ac4520d1553170b1053a9ffcd58179386a6d2.
Fixes an issue with Clang 18.
Needed for recognizing the `arm64-apple-darwin` triplet.
Needed since the current version cannot parse the `arm64-apple-darwin` triplet.
Allows upgrading libzip. Adding CMake as a dependency is inevitable as both upstream and Qt6 uses CMake as their build system.
The configure in the tarball does not recognize `arm64-apple-darwin`, re-generation fixes that.
b04bd2a
to
d046727
Compare
Just rebased, all green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This PR adds arm64-darwin support for depends. Also removes the LLVM toolchain from the depends, a recent version of clang is now required for MacOS cross builds.
Updates libzip to 1.10.1. CMake is now required for depends. bzip2 is removed from depends.
CD output tested on a M1 Mac, starts without an issue.