Add Intel GPU support status to whitelist #384
Conversation
|
The current GPU display uses an image for NVIDIA and AMD. Without adding one for Intel it won't display at all. I suggest making a separate PR if you want to implement Intel GPU support in the table. The priority for now should be fixing the GPU display for Milkyway |
|
Just now saw this after making my own PR from MW@H. Imo no need to list Intel GPU. There's many things we could list like OS support, if they run on Android, if they publish stats openly, etc but I think we should be careful to not confuse users with too many stats. (A "jumping off point" here to another page with more detailed project comparison would be nice though!) Intel GPU offers marginal performance improvements, in some cases you'd be better off just doing regular CPU crunching, and is only supported by a few projects. If we do list it, I think it's important to distinguish that the badge doesn't mean "supports Intel CPUs" since AMD users may see it and determine that their hardware is not supported. |
nathanielcwm
force-pushed
the
whitelistupdate
branch
from
21ceb9b to
cf8dbd0
Compare
|
Done @barton2526 |
|
Please also review gridcoin-community/Gridcoin-World-Site#46 when able |
nathanielcwm
changed the title
This was already done in #385 |
nathanielcwm
force-pushed
the
whitelistupdate
branch
from
cf8dbd0 to
6aa89d0
Compare
nathanielcwm
changed the title
Reduce resolution of Intel badge to 64x64px Downloaded from ark.intel.com
nathanielcwm
force-pushed
the
whitelistupdate
branch
from
1361a8f to
3de35f6
Compare
nathanielcwm
force-pushed
the
whitelistupdate
branch
from
3de35f6 to
e448cd0
Compare
|
I need comments around the usage of trademark vs registered trademark. The AMD and Intel text were both taken off the trademark notice on intel.com The Nvidia text was taken from the Nvidia brand guidelines and thus uses the term "registered trademark". But GeForce is undoubtedly not a registered trademark globally. Should I chnage it from "registered trademark" to "trademark", in line with Intel's usage? Or should I change it to "trademarks, or registered trademarks" like Intel's usage for some other trademarks (e,g, Windows)? |
|
Well a Google search seems to suggest that "trademarks, or registered trademarks" is the appropriate wording and this wording is also used on amd.com |
I believe the intent is to add badges for Intel Arc GPUs. These are not integrated GPUs. |
Ohh I see. Interesting. That would be cool to see there. |
guides/whitelist.htm
Outdated
| <div class="container"> | ||
| <p>GeForce is a trademark, or registered trademark, of NVIDIA Corporation.</p> | ||
| <p>Radeon is a trademark, or registered trademark, of Advanced Micro Devices, Inc.</p> | ||
| <p>Arc is a trademark, or registered trademark, of Intel Corporation.</p> | ||
| </div> |
There was a problem hiding this comment.
Maybe worth putting a small header here and just making this one <p> tag since it looks a little strange so space out (at least to me)
|
Have only a minor nit. The only other thing is if #386 is merged, you might also want to put these Arc GPU badges for mobile as well |
Move trademark notice into a single line
nathanielcwm
force-pushed
the
whitelistupdate
branch
from
f5ede71 to
a1f43e5
Compare
Also added a trademarks notice below the table.
Checked against each project's applications page and against boinc.berkerley.edu
Please squash merge this.