Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version #317

Closed
wants to merge 1 commit into from
Closed

update version #317

wants to merge 1 commit into from

Conversation

ahwagner
Copy link
Member

This is needed to update to the newest civic data dump. We should probably evaluate whether or not we actually want to keep this check for the civic:load task, especially if we start generating sanitized dumps on a regular basis.

@ahwagner ahwagner requested a review from acoffman May 15, 2017 19:40
Copy link
Member

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, actually we don't want to bump this. This versioning and load task are actually currently serving double duty.

Puppet still runs rake civic:load on each deploy (https://bitbucket.gsc.wustl.edu/projects/PUP/repos/puppet-modules/browse/site/apipe_civic_server/manifests/setup.pp#102). This is a hold over from when we were still bootstrapping the prod database from the local spreadsheet imports.

If we bump this version number, it will load the data from the data.sql on top of the existing production database which wouldn't be fun as we'd have to restore our prod database from backups :)

I should probably remove that check on deploy now that its no longer needed and we can reserve this load task just for local bootstrapping.

@ahwagner
Copy link
Member Author

Sounds good. I'm closing the PR and opened #318 so this can be addressed once the Puppet deploy code is updated.

@ahwagner ahwagner closed this May 15, 2017
@susannasiebert susannasiebert deleted the update-data-version branch November 6, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants